From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: toc-mode Date: Mon, 26 Sep 2022 21:39:18 +0530 Message-ID: <87illadsnl.fsf@gmail.com> References: <874jwvsmp8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Emacs Devel To: dalanicolai Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 26 19:40:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocs5k-0002Rw-Q5 for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 19:40:28 +0200 Original-Received: from localhost ([::1]:45058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocs5j-0007xH-P2 for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 13:40:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocqfm-0002kI-NV for emacs-devel@gnu.org; Mon, 26 Sep 2022 12:09:36 -0400 Original-Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:40684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocqfj-0003R6-UW for emacs-devel@gnu.org; Mon, 26 Sep 2022 12:09:34 -0400 Original-Received: by mail-pj1-x1041.google.com with SMTP id h8-20020a17090a054800b00205ccbae31eso382085pjf.5 for ; Mon, 26 Sep 2022 09:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=fvmiwqGv1DgI3fpkGNg9vrqF4B0s70tRIijjbQOrE6A=; b=YKAq81Y76nYGYDzLwGNBMGsoOnIZyzU1bdZfswW9hxLhJxhEM2YUyCh6o/2jB1E1Yk e13C6kUV6d33IiJh+8KloA8QDLOkjsOMOcFo+Khav8RrCbOFQDseAa9LfoRcDm5nnV+k cbkoa3csmLFA1eS368/j8BQqNbUtz4Zz16kVLFc/lVoLWsXs2xxNm6KWcdwntenfkEFg 7KJUrqAo3zBDihQrP2c6NfmfnYeN+OjtIwO3tO/EUq3daYi9GqUmJyn+PhuvjYqjwN9r IUy59U8b3V6HNVxQPylKQcb3sljy0HUk25S45by9HOBJxKlnAncbYl23w9UtQ2B56rT4 FV4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=fvmiwqGv1DgI3fpkGNg9vrqF4B0s70tRIijjbQOrE6A=; b=60hdyd64cKE5AwHU/1AaTeTXfL40vZCkHA9+GssAW3x828hPofgPQSoNIMcIk5awF0 shHswJgobpZ6H2VDe+wiw98dgiGUNMBX8HUPgA3YrxNt84tM4qgUD+SwTFP8TtzCWu3o REcFGBw9avvPKBgsqUjQvW8F+xegNltx8/VNyFj2xuSpEV80zyw0fyJgpggDNLwpdQu2 dt09vhTY2GyXCTcmCEbEFV3SMi3rkFtDlrJKXY1zpPIVtApiigaeAh4FZofRagrQIoha v4b0WMV4/UTTuuvf7o+ZT0fkbRD/2lU3sBEUO7Lc9LU5fROU6DkGpFz7LwsSMqC/W3Gb xKYg== X-Gm-Message-State: ACrzQf0U6qhSwILXZC/7QN2ZZypoY4XdN47ZmO+d3FClGcwjpqPEefhH Wq+PTDBcGgfg5LVzeWWcCjc= X-Google-Smtp-Source: AMsMyM6ELXj7Dd5FTrRJNwpciDVOHjmop2fjQLLfQyRTN0vQ3I3bQgSOhfeI71FEGz4xxdr2mf35Wg== X-Received: by 2002:a17:902:f684:b0:178:2fe:9f4b with SMTP id l4-20020a170902f68400b0017802fe9f4bmr21855312plg.60.1664208568911; Mon, 26 Sep 2022 09:09:28 -0700 (PDT) Original-Received: from localhost ([14.139.216.98]) by smtp.gmail.com with ESMTPSA id b16-20020a17090aa59000b002002f9eb8c4sm6795432pjq.12.2022.09.26.09.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 09:09:28 -0700 (PDT) In-Reply-To: (dalanicolai@gmail.com's message of "Sun, 25 Sep 2022 18:47:50 +0200") Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=visuweshm@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Sep 2022 13:29:36 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296294 Archived-At: [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=9A=E0=AF=86= =E0=AE=AA=E0=AF=8D=E0=AE=9F=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 25= , 2022] dalanicolai wrote: > Thanks for the feedback! Thank you for your answers! > However, I am not sure if I understand every point correctly. > > For point 1, I would say just keeping (S)- pressed works so > fast, that I think > it is not necessary to set the page number by reading from the user=20 Having to hold S- till the number increases by 20 is not fast enough, unfortunately. > As mentioned in the instructions for the tabular mode > > the contents of every field in tabular mode can be updated by reading > from the user through placing the cursor on the field and then > pressing C-r. I see now, that the phrasing of that instruction could > be a improved. I completely missed C-r since it wasn't mentioned in the Commentary section, nor does the command have a docstring. =F0=9F=99=83 > For point 2, the answer again is that you can press C-r on the field to > update it. I see now, thanks. > However, the tabular-mode should mainly be used for adjusting the page > numbers. Cleaning up, and setting levels, should preferably be done > in the 'cleanup' stage > . I figured it out but it took me some time to find out that whitespace governs the outline level. Maybe I missed the explanation in the Commentary since I skimmed it due to being in a hurry (my mistake!). > As far as I know, the most use keybindings are major-mode keybindings, and > automatically > listed when checking the mode documentation using C-h m, as mentioned in > the first section of the usage instructions > . Or are you thinking about > something else? I was thinking we could put the keybinding texts from the Commentary in the major-mode docstrings since it is hard to fish through all the bindings and find the toc-mode ones. ;; toc-mode (tablist) ;; TAB~ preview/jump-to-page ;; right/left toc-in/decrease-remaining ;; C-right/C-left toc-in/decrease-remaining and view page ;; S-right/S-left in/decrease pagenumber current entry ;; C-down/C-up scroll document other window (if document buffer = shown) ;; S-down/S-up full page scroll document other window ( idem ) ;; C-j toc--jump-to-next-entry-by-level [ Here, the Commentary section and the README file are out-of-sync. I tried `C-x v +' but it didn't pull any new changes, you might want to check this. ] =20=20 > Of course if you see any improvement, then patches are welcome (although I > prefer pull > requests, but all is fine). Sure, I will make a pull request.