From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] Add Agitate package Date: Tue, 27 Sep 2022 09:08:39 -0700 Message-ID: <87ill8er5k.fsf@melete.silentflame.com> References: <875yh9xsmx.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Protesilaos Stavrou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 18:36:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odDZN-0007xn-03 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 18:36:29 +0200 Original-Received: from localhost ([::1]:34414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odDZG-0006rC-Vb for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 12:36:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odD8V-0004E2-D3 for emacs-devel@gnu.org; Tue, 27 Sep 2022 12:08:43 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odD8T-0003A6-Rs for emacs-devel@gnu.org; Tue, 27 Sep 2022 12:08:43 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 95CC75C0144; Tue, 27 Sep 2022 12:08:40 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Sep 2022 12:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664294920; x=1664381320; bh=mh 6Clu3hcfJJpCNSlDCab1bMEvyz4lvd4QUnhr9h+gg=; b=HkdLdqYgGIMEyvi4du qifgL47a2zzrK3s7g/kaJfYWQaD1M6/8j5/M26k7bx3adE+oaj0UsTuulb7wqXfM rMlQFNSoCXDpOA0mrCnfj7C3nZNJMWZZBPDfdJI8X8TwIJOhXb9EPkhHYS1VEEGy oQDfFXjADFmEbwYbpYzXSBtwNb4KNE69iLr4QQqYL/TYrUQTfcwC9aSS95ZwQig+ EU8b3Z/Rf2jXPE+0acKkd35JeZ9+sp+FePJ6LazkYMtjCOJQWHQjddxhYEQb/u4o EMBkR/q0EvrAbzCno4FsSWqR7F9TR0Tib2Kcjlc9om5Sy2WllNaz63yYzece9wIU rnqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664294920; x=1664381320; bh=mh6Clu3hcfJJpCNSlDCab1bMEvyz 4lvd4QUnhr9h+gg=; b=f4oiOQNiW15/ViDO5VKf0DZRlhFq59m6LD2fXUL+Qvfm ki9FZrKGcJPQYUzB2h9p4dOBfWNC/mNpGNP/poruFgICBUQvEFG+QKCAMKpyMCg+ yd+/rkAobkEbCcfEkyony+5/vLzKn4VYF0c+fd5fLQvpm4srfrnBzU8sg7PjDl18 JtmVdD5pTSuCKSvTkgxuHhZ+Kyb2QGE3frXhSAny6zwyBBeFeACSpACo1ZGCv3Ps xZPOi4FMSZe+seuzgtAdGygLmN/x8oXMsQmMjXXfe3PSXfLFnjJgGlAXHaEy97Ir z1hFdItgpPKJ/3Aa9TG8tvtCRxMMVBoIuH+HoptM5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegiedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfggtgesthdttd dttddttdenucfhrhhomhepufgvrghnucghhhhithhtohhnuceoshhpfihhihhtthhonhes shhpfihhihhtthhonhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpedvvdehgefghfeuhf elkeduffehgfehkeefteekfffgffdvueefuefgudffhfduhfenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsphifhhhithhtohhnsehsphifhh hithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 12:08:40 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 751567E09C5; Tue, 27 Sep 2022 09:08:39 -0700 (MST) In-Reply-To: <875yh9xsmx.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 27 Sep 2022 09:01:42 +0300") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296348 Archived-At: Hello Prot, On Tue 27 Sep 2022 at 09:01AM +03, Protesilaos Stavrou wrote: > I want to install the attached patch on elpa.git. > > Agitate is a collection of commands or potentially useful functions > that expand on the available version control features of Emacs. Those > are meant to complement a workflow that relies on the built-in Version > Control framework and its accoutrements ('diff-mode.el', > 'log-view.el', 'log-edit.el', 'vc-git.el', and potentially others). > > The reason I am posting this here is because I want to ask if it is okay > to publish such a package, given that at least some of its code may be > better suited for emacs.git directly. I prefer the package format for > the time being, because it gives me (and others) the chance to refine > the code and decide on what is worth contributing to core Emacs. I just looked through the file. I recently read your prot-vc.el from your personal Emacs configuration, and I believe that most (or all?) of Agitate is a cleaned-up version of that? I think that it is always worth taking a fresh look at one's personal code and seeing if versions of parts of it might be upstreamable, so thank you for your work. One does have to accept, as I'm sure you realise, that some things will be too idiosyncratic or personal to be much use to others. So it's reasonable to assume, given its origin, that Agitate is a mixture of things that should eventually go into emacs.git and things which should not. In that case, it doesn't make too much sense to me to add it to ELPA, but not for the reasons that you give. It's not that code which is targeting emacs.git cannot go on ELPA first, but it seems to me that anything on ELPA should be a coherent, singular package. And Agitate isn't that -- it's a collection of functionality that you're filtering things out of over time. For myself, I'm looking forward to seeing some of this in core. -- Sean Whitton