From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 59df0a7bd9: Add a VC command to prepare patches Date: Sat, 08 Oct 2022 10:51:02 -0700 Message-ID: <87ilkub3w9.fsf@melete.silentflame.com> References: <166522273249.875.4607071661972312638@vcs2.savannah.gnu.org> <20221008095212.D8BB0C21CF8@vcs2.savannah.gnu.org> <87r0zib5d4.fsf@melete.silentflame.com> <87y1tqp6l6.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: Philip Kaludercic , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 19:52:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohDzd-0006SD-L4 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 19:52:10 +0200 Original-Received: from localhost ([::1]:44302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohDzc-0004n7-Fk for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 13:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDyc-0003x4-Jq for emacs-devel@gnu.org; Sat, 08 Oct 2022 13:51:06 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohDya-0001m2-0u for emacs-devel@gnu.org; Sat, 08 Oct 2022 13:51:06 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 910835C0095; Sat, 8 Oct 2022 13:51:03 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 08 Oct 2022 13:51:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1665251463; x=1665337863; bh=SfdjQmIX7V EXsV015rasyYGKfHBIsf/9CmKieSA0ylQ=; b=V30Rn3xegQBs4UVATjDv/yinoS 5w45GscJ1VuCeKimOY7h7F9B2PaU6eY16ePweUhc3akSdsmS4VF4Oilhh11cSBJy eZ92woq5KU1HmQ3NVxKUkEtVMMjU8DSfrT531orEBG4Afyg7/cvBC42nFIzCKWRx xfdXURLh4Hm9rTdFZtY3QrZ5vuEcYZp1igUruH1B9BfoSD790B0zPsYkbfxESXI0 vcGONLG3ah6S+B30UaVSpcmaOXNMjSSMoTpc/2fRGzY7Bdv2Bo0rD7pVCqJAIxdY 4C5hMCPIGQ7Lw/n566tJ7WHD8NDtoP9z/2tgzJk+TPZXR+p5N2JsJpdd319A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665251463; x=1665337863; bh=SfdjQmIX7VEXsV015rasyYGKfHBI sf/9CmKieSA0ylQ=; b=XNwTFiU0H2LAA65c0VU2FIbfSW9K1UDVu57kOe2xKsaU nhG9fGmF+9IznUmoOipwHVh//SbOaaAchTy+BzCY7IWHkzVcK1g7FZSfsK5XXcTQ Ddc53135oAEzrvxgzkRTtTzciAm9ZECKHiMQZ/3XaBP4a1k3hKzOdBQpiHj1nyNB I7w24isRBXqylXBm4QANJtUMMy8lu36F6qu5leMtGASha62oRg0yYOfk4LE36aum iB1nU6oYZdJ1+budFvSEkSEjVcUX5merrkSZcjEZvAGIHb2oCzz+bPlU8NXElJYT vVfdpBHFUrUwbGMaj2p6qW6ajhfdgFE03BFQctwMbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeiledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Oct 2022 13:51:03 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 954677F3E5B; Sat, 8 Oct 2022 10:51:02 -0700 (MST) In-Reply-To: <87y1tqp6l6.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 08 Oct 2022 17:29:09 +0000") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297217 Archived-At: Hello, On Sat 08 Oct 2022 at 05:29PM GMT, Philip Kaludercic wrote: > Yes, but I would wait a bit to avoid the same issues as we had when > `diff-add-log-use-relative-names' was set. Anyone who had pulled the > new commits with the change but hadn't rebuilt Emacs to know that these > are safe values was prompted the "are you sure these variables are safe" > queries. If we wait for a week or two then I would guess that most > people following development will have pulled and rebuilt at least once > by then. Cool. Perhaps the docstring for vc-prepare-patches-separately should also mention that it can be set locally, then? (Btw, just filed a feature request, but forgot to X-debbugs-cc you.) Thanks for this cool new feature. -- Sean Whitton