From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package-vc has been merged Date: Mon, 07 Nov 2022 16:58:51 +0000 Message-ID: <87iljqya44.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <878rkxgpms.fsf@posteo.net> <87sfiyk3a2.fsf_-_@posteo.net> <838rkp4ptj.fsf@gnu.org> <87zgd58i7y.fsf@posteo.net> <83k0492u5i.fsf@gnu.org> <87fsew8g18.fsf@posteo.net> <83mt941cyd.fsf@gnu.org> <87fsewp0ec.fsf@posteo.net> <837d0814c9.fsf@gnu.org> <878rkooz1o.fsf@posteo.net> <831qqg1306.fsf@gnu.org> <874jvcowzm.fsf@posteo.net> <83y1soypvx.fsf@gnu.org> <87y1song5x.fsf@posteo.net> <83v8nsyof7.fsf@gnu.org> <87leoond7l.fsf@posteo.net> <83r0yfzz01.fsf@gnu.org> <87bkpjyx3p.fsf@posteo.net> <83bkpjynmj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34497"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 07 17:59:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os5TH-0008hO-EC for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Nov 2022 17:59:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1os5Sd-00056c-G9; Mon, 07 Nov 2022 11:58:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os5Sc-00056T-GV for emacs-devel@gnu.org; Mon, 07 Nov 2022 11:58:58 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os5SZ-0007Pf-Ho for emacs-devel@gnu.org; Mon, 07 Nov 2022 11:58:58 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8C6EB24002A for ; Mon, 7 Nov 2022 17:58:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667840333; bh=1ZziWzcTNqImIJn6gmO4iOkoptvH+0/JJ95FCAiJNM4=; h=From:To:Cc:Subject:Date:From; b=pBoDj6JhnBqzt1KGs/5RW13cE/uyDuQ+24nVMZ79bXkvC4ZBbbqikSCkltQdQnsIT cpATsPFd9D0OfwGvyD6QZ/vcN+eUHr533NvqeZFseRLMyKgpKnjSK6AHMnHPxbz+rx ZCy4TqiqtExdgrWlmrWZQl/IeiGYat0gP9mOiYyJBI0MBwXnIHh+Czh7UL++Y2NOYu 1Bodmw8izlVHI1xHfe6/VmLg36ZzfO292S/qyPeBHWHAMks6vJkIOiFjgafZkdS6qg VjtQ5cOU4I2Hd4ZbEYGMLBVhYH2BDKZ/sH/BhxZNHZtvbhrcZ4z5Yvos2s/RIzX25k hv/GwA6GPS2Jg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N5crX3kFCz6tmK; Mon, 7 Nov 2022 17:58:52 +0100 (CET) In-Reply-To: <83bkpjynmj.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Nov 2022 14:07:00 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299297 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org >> Date: Mon, 07 Nov 2022 08:42:18 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Philip Kaludercic >> >> Cc: monnier@iro.umontreal.ca, rms@gnu.org, emacs-devel@gnu.org >> >> Date: Sun, 06 Nov 2022 18:35:10 +0000 >> >> >> >> Eli Zaretskii writes: >> >> >> >> > And if you think many do, why not clone the repository directly into >> >> > ~/.emacs.d/elpa/? >> >> >> >> Because that won't take care of scraping for autoloads, byte >> >> compilation and installing missing dependencies. >> > >> > I don't see why. Please elaborate how having the repository inside >> > ~/.emacs.d gets in the way of these activities. >> >> It doesn't get in the way, the issue just is that if you were to just >> clone a package right into .emacs.d, you would still have to do all >> these steps individually and manually. > > Which steps are those, and why do we have to do it manually? Let us assume `default-directory' is (locate-user-emacs-file "elpa"). If I run "M-! git clone https://some.git.host.com/path/to/repo/foo.git", then I'll just have a directory called "foo", right? If I want to byte compile the files I'd e.g. have to open foo in Dired, mark all Emacs Lisp files, byte compile them, then run something like `make-directory-autoloads' myself. Then I'd have to find the main file, check the dependency list and run M-x package-install on every one that is missing, again one-by-one. You don't have to do this for `package-install', because it invokes `package-unpack' that takes care of those details. As package-vc-install doesn't use prepared tarballs, the equivalent process is a bit different (thus we have `package-vc-unpack'), but the intention is the same. Bundle all the repetitive task into a single command. >> >> You mean as in only allowing for packages to distribute lisp code in the >> >> root directory of the repository? That would pointlessly break too many >> >> packages that decide to structure their file hierarchy for whatever >> >> reason. >> > >> > Is that what :lisp-dir is about? then the doc strings in package-vc.el >> > doesn't even hint about that. In particular, there's nothing there >> > about the root directory of the repository. >> >> The docstring for `package-vc--archive-spec-alist' has the following >> (I'm still looking for a better way to document this): >> >> `:lisp-dir' (string) >> The repository-relative name of the directory to use for loading the Lisp >> sources. If not given, the value defaults to the root directory >> of the repository. > > Ah, it's a misunderstanding. See below. > >> > (Not that I understand >> > why having Lisp files in a subdirectory of the repository would be a >> > problem that needs an explicit configuration of the package, probably >> > missing something else again.) >> >> Maybe I am mistaken, but having a directory in `load-path' doesn't mean >> all sub-directories are automatically indexed, right? > > We have a standard solution for that: > normal-top-level-add-subdirs-to-load-path. We install in any > directory that needs this a file called subdirs.el with the following > contents: > > (if (fboundp 'normal-top-level-add-subdirs-to-load-path) > (normal-top-level-add-subdirs-to-load-path)) > > Example of directories which need this is the site-lisp directory. I was not familiar with this function. > Why cannot we do something like this in this case? I would have to try this out, but my worry is that in some cases this could add too many non-lisp directories. It still seems more elegant to encode what the lisp directory is in the package description.