From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter 3069849bd4 4/4: * src/treesit.c (treesit_load_language): Fix uninitialized uses. Date: Mon, 21 Nov 2022 19:59:28 +0800 Message-ID: <87ilj85xi7.fsf@yahoo.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12035"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 21 13:00:26 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox5TN-0002yA-U3 for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Nov 2022 13:00:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox5Si-00078z-LX; Mon, 21 Nov 2022 06:59:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox5Sg-00078i-Ha for emacs-devel@gnu.org; Mon, 21 Nov 2022 06:59:42 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox5Se-0001mn-K2 for emacs-devel@gnu.org; Mon, 21 Nov 2022 06:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669031977; bh=B6Zn4wg34rzUvuV96H1+zm9ako1jkcGpqmiNmHne6zI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qcSYEboYvnx5elkKJ+vZPvKzZq7E6ZIcqFGe9/ZSHt7RA1jJv9I5PvCxcNvzOpfaNozsAhMPk+o/TziNzrBycHNyJkQpXHsfoZ2gPxUgQrX725gGDjsiL4dHjU/0VtPPnd2JYaBX4eSmkXkTtlyKBC2Xb3N53/F2PsibqK/4+/o5aBFjICTSuvVz46uhHt++r9vNnJgJOHaPwIm1iT9Lc29P3CRB9AWefKDe1taT87cjazDSvUQ8f2HQhnJa58oFI48OG64RosMS408M/KpCnei7CwMLsvJ9zPm30sgeikj0sv+LqSkf6/jwxDfoc9eIXL+o3+KY4xYsriBQNvK71A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1669031977; bh=TQlg3w5QRZ3G9ThCGbGvTf/Nm3hLSRm2qiHM5YD5J/R=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jA/jBEtvOgGBRUmeIl3KL+B4Hgv9gzHdN1j3JYeDgbYqifXr73vQ9I3zkGhYsyv8u07uTIZcHU1TfSXq7AeOlZV+GmXSBqFpAFdUk0shdZgBdjYFGnxT3bCn8tBOArzHEkMwatMmvni64fn6TElgTozxnoA8jYmDjz+G5QuzQwP79bUiTtxUpVms+Ljl9sTWqVfJfPD4ESBOs90cVet1WqxPoNTO3vSWdESlKehm1/OmHrQhwSHzgYDbd6jS43YK8Uhh5EoGG1zjyP83tOMc7XSPsbeiB3zBDgvw7BHUs3eBF4UiXef1L7LuNEk1v53hVOeVFJBddum+JqIgTAw2LQ== X-YMail-OSG: H6.fFhgVM1l1sLozz8Jd4iEoYweRVfL7vHFwJUUUYSJ.CWF5pOAxEanIRuAOzH4 mGE4cXLpKBjVVkXCSW6SVh2CilQWW92A4_qBxVRigMzy5YcjrjWQP64t27Im4v1oqMZ8C4fcEEei 9Q2HmNx1Fc._j9Yrd783t0go.pBLDWPfjiwe9WHRfSxbGM7Jq0so.OQ8.D8h3t08vaZpm2zGK.5F LQFrYNWCKJLn4HRbZytRmFVr59Xxa5ZCMvHphsBrIP3fTpLxQWmlPE5ODgxcY7m81lhEY_3aiV.z MciaUSpk0t_fD2_8_Z88GfhRs7N0XQbdD3ICvavrMyx_h_bUT7Zk4t2nAy20LC3ed7jCCedIEjgn gYKMvw7qFDeRJPtry1azc.NOyAI23e6VT.KhqCKZCibogtmD_WF7Be2ZoG08q8JXAfPSOAAGi0wM GHOt4DdYcNOYjaItNJObphrufmb6oqXMEU9D8knMdTRJMzUnY45.AxKIpduU_2HZMahwWPwi7Acv U1TRF7_h7oDGvlUDTTIoTSuvIbThQghXmTRJATDsQVAd1Z9cOlL8PxCc719OtSB7LWq75fQe4s87 n1PaH5WzyIeY3G3roqLBSbxhH7W.TBs_14YVHfPxgSwZiD9cmeYtlZdlME4IYBYUZhOg7AammRGi iTOGgkx1fmAyVtP.YPem7b35GEV8uwJfsuv1zQRIU8qqqzS.lrVZ53S74jqyBI7FVGCTtYHyLo.W elEk3M3pj6vsHH4u85aIBCKORVAR2EY5vNAIa2IZkYsljB_pVKzq309jvPYSj1R.7ax167xyaseo C6haZAAaNY3QsWs6Q7xSvKrNVmDRMgrvret1FGfhLe X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 21 Nov 2022 11:59:37 +0000 Original-Received: by hermes--production-sg3-6c8895b545-mnqst (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e594eb060e9dea20b5c656b2edf9ff52; Mon, 21 Nov 2022 11:59:33 +0000 (UTC) In-Reply-To: (Yuan Fu's message of "Mon, 21 Nov 2022 01:37:13 -0800") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300290 Archived-At: Yuan Fu writes: > branch: feature/tree-sitter > commit 3069849bd4c1048a8f8c0467d26560fad939e791 > Author: Po Lu > Commit: Po Lu > > * src/treesit.c (treesit_load_language): Fix uninitialized uses. > --- > src/treesit.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/treesit.c b/src/treesit.c > index 291698e4e4..599a9b883e 100644 > --- a/src/treesit.c > +++ b/src/treesit.c > @@ -554,9 +554,11 @@ treesit_load_language (Lisp_Object language_symbol, > when succeed, record the error message and try the next one when > fail. */ > dynlib_handle_ptr handle; > - char const *error; > + const char *error; > > tail = path_candidates; > + error = NULL; > + handle = NULL; > > FOR_EACH_TAIL (tail) > { > @@ -568,6 +570,9 @@ treesit_load_language (Lisp_Object language_symbol, > break; > } > > + /* ??? */ > + eassume (handle != NULL); > + > if (error != NULL) > { > *signal_symbol = Qtreesit_load_language_error; > > Thanks for working on this. What does ??? mean? Why do we assume > handle is not NULL? handle can only be set if tail is non-nil, but I do not think that is always the case. The code below seemed to call dynlib_sym (handle, c_name) without any checks. I was going to ask about it, but I forgot.