From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: file-equal-p Date: Thu, 16 Feb 2023 11:35:42 +0100 Message-ID: <87ilg199tt.fsf@gmx.de> References: <87a61es8fh.fsf.ref@yahoo.com> <87a61es8fh.fsf@yahoo.com> <83fsb681me.fsf@gnu.org> <87pmaaq9ua.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Po Lu , Eli Zaretskii , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 16 11:36:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSbcs-0002RM-4x for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Feb 2023 11:36:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSbcF-0003cU-Hh; Thu, 16 Feb 2023 05:35:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSbcE-0003cF-G4 for emacs-devel@gnu.org; Thu, 16 Feb 2023 05:35:50 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSbcB-0001kj-Va; Thu, 16 Feb 2023 05:35:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1676543743; i=michael.albinus@gmx.de; bh=GS2PSbdbDn/9zxCKei+A4z/Xvzvycu2uCHkU6l4Uo0w=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=mCniw5uquRK2Qij6yEI0510Rw5EexPlTEpf1cKHpZmleNhm8i2mWeoPPudMRncqem J4sx1o5VHx7DBxh6H/hXYONrQIJeOH1NlLvJaGRuMmO7HkEQhZ8q9TA0OIVfJF/FS0 41RardzudUo4JSSCXA2zppYRKNGHB/wVqO3bl6efS0vWWt4Jg84PE0uJKr6gUJVyDr 0Ei/sSpW29l8TTF+tkdJWoYc8JlNPGKM+/1uVXfyTVxNJhFlUi6P4RFqfHaxabCerD O4dwyk6wwB6yLdoNnKS3aQPOen/sRLHgu+fcai7AVA0S446XcMEUgmKoaSsaFHQeGA IKvnpJygr0ewA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.22]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1Hdq-1pPrWP0jgg-002mHt; Thu, 16 Feb 2023 11:35:43 +0100 In-Reply-To: (Andreas Schwab's message of "Thu, 16 Feb 2023 10:15:07 +0100") X-Provags-ID: V03:K1:bITnfNHKLOkwKnJebWr/gSPSbw6m+6CgMR91A94JF0yOp8jZeH/ HbUzanaOf13+e2kjRzSSIeUL1MHLcLYYKl0I0vX9qZXfWu24kb4JKRzezufm6SuMnkbUpUr 7W1Q+reEMKFQkQ46qZaKb1UGqAvlnxuRZwOw6jowWq71wKY1QaQ3DMAGwHZj0wYkyEj+/EV Tfv5GJSxFvfMPE/n94tTw== UI-OutboundReport: notjunk:1;M01:P0:Z9mcRcgTbk8=;YI1xt+BMUvNaySwWBfQqNjLKmKc lUUksUXt0iKMWTeKeTdSPAr3pfH383+mfiyGY25jeqt4KkvVreLWXD/ZJkE95aGhjVOhwdrUU re/pmg2yjKlWHG+DCN4ZAiZiLd88AKydyyvLkGcce4MHNLFsP9p2ej4xJV8JKPn7vUwGAdfPB UQqrpNMOukjRDyMo5XpdNCWM7rwMuQ1R6Qq6dFYlkkseRnGsXZzLics0GCE6N+krgoQ2NjphM LOE0KZOTHLWyImYrcB042qfN0pCwJWy86yy9mJeUbExuXojyqfVxO5mVkpLQYCgBKQJDJWHM3 i4iMqwrugFyDaptQNsq6lTFWMLBJ3zoBR8Yjis9DsO7okMdikJ2e4XhUW4bdZm/J9LH4ltnrN y/hkIAdozfC6ZbPNVZVQOJ083pMp8cm0gVAEeKFir/NGd63cckc9hjwTFzKb+ZPy1UG5b3Qzw Ktf6mRqn0O1GvEIB8AP6YeARSTmJEXyTmNYHXIfbop7TNXV/En9iZAQZFnw/DVASZ9uVd25xo 4h3WLHeOZLSN/kLKW2JvEPWam0U3plKgemfzcYqGh7j6Ypkqop5QqIZr+x4mkgpy7TYa3mIJD r9uKA3dOcGdGAZtD/Yi/qWFEnrNbxN/qbGYBfBS3IR7/wrLU+aZCb0F2gXb79FV/U4lNEz6QJ 3NTJns/jlrmgtXniUvjbQBRntFar+n5Ur5MJkBvtncTUzDareauLPeRfbDT6mw6CvYuLCz8u0 mXr96Io9QHqtcmZ/ie4WrX58lZcYAXGyxnYWtYlRaA+kdA3NFLRjEgeU86u8bzGkWHUF5+2s Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303397 Archived-At: Andreas Schwab writes: Hi, > On Feb 16 2023, Po Lu wrote: > >> diff --git a/lisp/files.el b/lisp/files.el >> index b0ec6bb09d0..dcd17df166a 100644 >> --- a/lisp/files.el >> +++ b/lisp/files.el >> @@ -6360,7 +6360,17 @@ file-equal-p >> (let (f1-attr f2-attr) >> (and (setq f1-attr (file-attributes (file-truename file1))) >> (setq f2-attr (file-attributes (file-truename file2))) >> - (equal f1-attr f2-attr)))))) >> + (progn >> + ;; Haiku systems change the file's last access timestamp >> + ;; every time `stat' is called. Make sure to not compare >> + ;; the timestamps in that case. >> + (when (and (eq system-type 'haiku) >> + (consp (nthcdr 4 f1-attr)) >> + (consp (nthcdr 4 f2-attr))) >> + (ignore-errors >> + (setcar (nthcdr 4 f1-attr) nil) >> + (setcar (nthcdr 4 f2-attr) nil))) >> + (equal f1-attr f2-attr))))))) > > Why does that compare more than the inode and device number? The other > attributes can change any time, if another process accesses the file or > modifies the inode between the two calls of file-attribute. For this we have file-attribute-file-identifier. So it might be sufficient to call --8<---------------cut here---------------start------------->8--- (equal (file-attribute-file-identifier f1-attr) (file-attribute-file-identifier f2-attr)) --8<---------------cut here---------------end--------------->8--- Best regards, Michael.