From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: Merging feature/android Date: Fri, 17 Mar 2023 19:27:24 +0800 Message-ID: <87ilez39er.fsf@yahoo.com> References: <87edq7ztks.fsf.ref@yahoo.com> <87r0tr79oe.fsf@yahoo.com> <86jzzjmp9h.fsf@gnu.org> <87mt4f788u.fsf@yahoo.com> <83fsa7s3yz.fsf@gnu.org> <87edpq7tke.fsf@yahoo.com> <875yb27qe8.fsf@yahoo.com> <87ttym5vgj.fsf@yahoo.com> <87sfe540or.fsf@yahoo.com> <86bkkt3wpb.fsf@gnu.org> <837cvhq8m3.fsf@gnu.org> <864jqkzz3p.fsf@gnu.org> <835yb0rjel.fsf@gnu.org> <86zg8cyjvq.fsf@gnu.org> <834jqkrdk6.fsf@gnu.org> <86pm98y66e.fsf@gnu.org> <83zg8cpj6h.fsf@gnu.org> <86a60bn4z1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , corwin@bru.st, emacs-devel@gnu.org To: Arash Esbati Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 17 12:28:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pd8GE-0008BH-Tk for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Mar 2023 12:28:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pd8FM-00089N-GN; Fri, 17 Mar 2023 07:27:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pd8FI-00088r-Ju for emacs-devel@gnu.org; Fri, 17 Mar 2023 07:27:40 -0400 Original-Received: from sonic313-56.consmr.mail.ne1.yahoo.com ([66.163.185.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pd8FG-0000Zf-B5 for emacs-devel@gnu.org; Fri, 17 Mar 2023 07:27:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679052455; bh=CN8efO01TzUj+XIhl9AbgoxZT5iDykm8i2Foy5RqB/4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=DteAsapqe3fKvuOmwPq5Ss76LTPsNtZBEhPWtCjcyq3EuSLPvCEFDsohPX+Fu73AojtdgSZVrpWQMtJVKjGYqBK9/ok9URXxhwlnC4vup78vkMgIjNFk2ysOZLtYwWyhvqT4zQBKTAy/YMDMoheeo+F3QXg0p1t6ZGtLtqitVP3/lzj4w/RRSubSYAzEBnGh6J5nAyd2aVBcs8WCEvE3z4bzxm8uNI3hy18RSQKJs29iGBZAYFj/s0IChfuUA9pceJ/nLZ7qAfW6TwLSnjhqcCpOMaSUrSIiDFLCurJ4pX19yzOaTwv8J5QMkEoeg3DA8YALbEXIfKwWxgnepiEWbg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679052455; bh=z+KTlcKcaGAds4brhxV0tdzzN/6Cn3wRd88RKcphxjc=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FuC3YMga6nzrB3ySAVSPhm/15YZsHAzh0n+ycVea+6ty3X6yMaKMY02vS9xfcNTLun4bJWwhxRUxVQ4zE1fdAInjLElKQYENfh+skgAck9oLyXXJWEfofyWPQy01VXkDLUeZKts/lWXbd6Ewxi8ZDpkTBv9ATRsCnNiYqmKltNy8KsIuO+vIfn4y8OwJsBMmGvRvCHX0MauZ4yctfZWx5OEARwgAOVG5TRS+7lWvDDLHZgBQ7grHaCw+H4aBDHOp3uv8C88IYNHoJ3olOV+jFUsiRt3vG6XZ/AM+2uyaQdteLWmTV+7X43gMonaIbgjMNmEVeV1+Z/wxPoNY8EZPRg== X-YMail-OSG: M_c93MYVM1lBWkKX88nvvmOW5Yz0jYAzz45CIb5eqx83esAU6ElKl5B89axGqFZ kuP5lNnT8LEUo2lQ_X05NMGN86xs61OMLaz3ArizffYOFVV9yQTrzRrh4sBfvhq62d5W5ylDVJxD ZxAQhDvAXmNw_n2a6PtCpj.IJEJAFdbT19nJZFc4WXH3ig8t_4dqsI9uNojt6RZvepqIggqW2IpT FyYZiqJTMioIdG.bTfyRIXctQjjkkQRf5QtdPTNa216gMnhB5Ax37zr6KPH5RRB5nXH3.fUFJc35 i3k2jSXtanOlaeQ8FB7koaeHgxji_iRT4BfRFaez8pHipUq6KVEQaAKIV_MM_LS0g3lsxm2hmbj3 00t0r_bxYzMK8fQMYcWLFV_Y_otbMgT6AriVfTBuOnaSNf22co5T0y5aNhY3bmTI8OG3Gz9L767I f1WV_Fzy1bRaxu3Kuf0v.s61N_AiFduzjJzx2ZiUlcYPVmtq.pvN62nSAAckK_kxgpltF7DmwIG4 BtDPXHYK_.NOa6NmtATQZwR8TiC2VUkIOgPJzRze78m5ojB4PAHMjH1mJdfIGuaUcixtphGxIGgY m.SHrLHdy2xSPKiuhst_k1pOgbQb3.II62ZsKgCrNSlWzI8N0VE6UYb5Dr.KdtcnrrUKZJEm00rT _gHs03I8Vo3LKyn8KPimjhe8xEIyFMep7DmZk85.8OiXDhx4EsWQyVBr2lB.Ry6Y08LBHJze4Zny 10nybs.GR_PsYFGtXhM.QSBKJkxo.5jEQf__ivijQdqnuLIWaPT_IgDkRJPfQqclcVsuQJIgPKqv T5ErFccmY6fipcUUboV24lWV3sAeqk7uQNBFMwGqd. X-Sonic-MF: X-Sonic-ID: 902e0839-1589-4519-ac22-4e409435e3b2 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Fri, 17 Mar 2023 11:27:35 +0000 Original-Received: by hermes--production-sg3-67c57bccff-l2hjz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 47c59797d54bdc98bc1b89e5a74f87af; Fri, 17 Mar 2023 11:27:30 +0000 (UTC) In-Reply-To: <86a60bn4z1.fsf@gnu.org> (Arash Esbati's message of "Fri, 17 Mar 2023 09:42:58 +0100") X-Mailer: WebService/1.1.21311 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.31; envelope-from=luangruo@yahoo.com; helo=sonic313-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304543 Archived-At: Arash Esbati writes: > Eli Zaretskii writes: > >> That doesn't necessarily prove they are the same. Please compare the >> values of WARN_CFLAGS in src/Makefile between the two branches. > > Thanks. This is from master (line breaks added manually): > > WARN_CFLAGS = -fno-common -Wall -Warith-conversion -Wdate-time > -Wdisabled-optimization -Wdouble-promotion -Wduplicated-cond -Wextra > -Wformat-signedness -Winit-self -Winvalid-pch -Wlogical-op > -Wmissing-declarations -Wmissing-include-dirs -Wmissing-prototypes > -Wnested-externs -Wnull-dereference -Wold-style-definition -Wopenmp-simd > -Wpacked -Wpointer-arith -Wstrict-prototypes > -Wsuggest-attribute=noreturn -Wsuggest-final-methods > -Wsuggest-final-types -Wtrampolines -Wuninitialized -Wunknown-pragmas > -Wunused-macros -Wvariadic-macros -Wvector-operation-performance > -Wwrite-strings -Warray-bounds=2 -Wattribute-alias=2 -Wformat=2 > -Wformat-truncation=2 -Wimplicit-fallthrough=5 -Wshift-overflow=2 > -Wuse-after-free=3 -Wvla-larger-than=4031 > -Wno-missing-field-initializers -Wno-override-init -Wno-sign-compare > -Wno-type-limits -Wno-unused-parameter -Wno-format-nonliteral > -Wno-bidi-chars -Wno-pointer-sign > > This is from feature/android: > > WARN_CFLAGS = > > And while looking at the diff: > > master uses the -isystem flag, feature branch uses -I, e.g.: > > WEBP_CFLAGS= -isystem C:/msys64/mingw64/include/webp (master) > WEBP_CFLAGS= -IC:/msys64/mingw64/include/webp (feature/android) > > Best, Arash I think I've fixed this now. Would you please test on MinGW to make sure?