From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sebastian Poeplau Newsgroups: gmane.emacs.devel Subject: Re: eglot's interface for major modes Date: Sat, 08 Apr 2023 11:37:18 +0200 Message-ID: <87ile63e02.fsf@mailbox.org> References: <874jpr35eh.fsf@mailbox.org> <86v8i7tmda.fsf@stephe-leake.org> <87jzymzqh2.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2886"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stephen Leake , emacs-devel@gnu.org To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Apr 08 15:20:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl8Uy-0000Ud-0U for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Apr 2023 15:20:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pl8Tt-0007iU-7s; Sat, 08 Apr 2023 09:19:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl578-00018c-ER for emacs-devel@gnu.org; Sat, 08 Apr 2023 05:44:06 -0400 Original-Received: from mout-p-103.mailbox.org ([2001:67c:2050:0:465::103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pl576-0001FA-Lq for emacs-devel@gnu.org; Sat, 08 Apr 2023 05:44:06 -0400 Original-Received: from smtp1.mailbox.org (unknown [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Ptr0b1brWz9sWV; Sat, 8 Apr 2023 11:43:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1680947039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=acDXU17Hs/dbqIDc46rjy256EpRsKTWTM+6lpdTa+ys=; b=HVSZ+Tzmh8SF7yXrrrYHsF4XtqfEAV781LMPiAcwXRbdwWFtLs6xKzPF/9HTyWKYh1hhBc TN48bQEfncKnFg9hEbgcBDBORhtceRClLbcu3L0D2JMywca5manrZRxm8U/haLdFGJXKpz fcSuPkGkImIaZyhvcJdJ/Tah0AVVNNgbSgT4Xm90ogkd9ttAKoK6Q3pZeyXO8m1zkKW6ob +EQwTZewdjNbCQDCeag8GJqfYqKhWobUgMksp1rU1D5saeJkDFLobXOIgrJFU9oVrXty4q NbL/iwvnuJlBtgCfDrQjFaJMHXT5jXe5x3RORnPPEf/ZzFJ2AZ2CbpLbWLIJFQ== In-reply-to: <87jzymzqh2.fsf@betli.tmit.bme.hu> X-MBO-RS-META: rmkhrexygkzfe16p7p7fdq34pa1hn3qb X-MBO-RS-ID: 88bcdfc70bd905559db Received-SPF: pass client-ip=2001:67c:2050:0:465::103; envelope-from=sebastian.poeplau@mailbox.org; helo=mout-p-103.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 08 Apr 2023 09:19:48 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305185 Archived-At: >> (defun ada-light-other-file () > > Would it make sense to locally set ff-other-file-alist to this? That > way, users can globally bind ff-find-other-file and make it work with > both c-mode and ada-light-mode. I may be mistaken, but my understanding of ff-other-file-alist is that it needs to be set to a mapping between file extensions of specification and implementation files; whatever the value, ff-find-other-file will use the algorithm in find-file.el. My function, on the other hand, relies on the language server to locate the "other file". But maybe one could recommend that users remap their binding for ff-find-other-file to ada-light-other-file in ada-light-mode. >>> 2. Should the handler for "window/showDocument" be part of eglot? > > See bug#62116 Thanks for the pointer! Great to see that it's already being worked on.