From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Valtteri Vuorikoski <vuori@notcom.org>
Subject: Re: emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses
Date: Sun, 16 Jul 2023 18:02:44 +0800 [thread overview]
Message-ID: <87ilak898b.fsf@yahoo.com> (raw)
In-Reply-To: <20230715081357.2B622C06C71@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 04:13:57 -0400 (EDT)")
Eli Zaretskii <eliz@gnu.org> writes:
> branch: emacs-29
> commit b54febef5d735efdc907c5e5cd016bed74e338a8
> Author: Valtteri Vuorikoski <vuori@notcom.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Fix NetBSD build with and without ncurses
>
> * configure.ac (netbsd): Don't set TERMINFO=no unless the termcap
> library is either -ltermcap or -lcurses. This prevents aborts
> because on recent versions of NetBSD libtermcap is actually a
> symlink to libterminfo. (Bug#64577)
>
> Copyright-paperwork-exempt: yes
> ---
> configure.ac | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 19575e80cf4..df74f8cd2f8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -5212,7 +5212,11 @@ fail;
> ;;
>
> netbsd)
> - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then
> + # NetBSD versions prior to 6.0 lack native terminfo, but have a
> + # tputs() built on top of termcap in these libraries. Use native
> + # termcap instead in this case. NetBSD >= 6.0 has native terminfo
> + # implementation in -lterminfo.
> + if test "x$LIBS_TERMCAP" = "x-ltermcap" -o "x$LIBS_TERMCAP" = "x-lcurses"; then
From (autoconf)Portable Shell:
The `-a', `-o', `(', and `)' operands are not present in all
implementations, and have been marked obsolete by Posix 2008. This
is because there are inherent ambiguities in using them. For
example, `test "$1" -a "$2"' looks like a binary operator to check
whether two strings are both non-empty, but if `$1' is the literal
`!', then some implementations of `test'' treat it as a negation of
the unary operator `-a'.
Will anyone object if I change this to:
AS_IF([test "x$LIBS_TERMCAP" != "x-lterminfo" \
|| test "x$LIBS_TERMCAP" = "x-lcurses"],
[...])
on the release branch?
next parent reply other threads:[~2023-07-16 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168940883684.23439.12214259073355647832@vcs2.savannah.gnu.org>
[not found] ` <20230715081357.2B622C06C71@vcs2.savannah.gnu.org>
2023-07-16 10:02 ` Po Lu [this message]
2023-07-16 10:31 ` emacs-29 b54febef5d7: Fix NetBSD build with and without ncurses Eli Zaretskii
2023-07-16 11:55 ` Po Lu
2023-07-16 12:56 ` Eli Zaretskii
2023-07-16 13:44 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilak898b.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=vuori@notcom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).