From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Transient manual Date: Sat, 02 Sep 2023 17:12:49 +0000 Message-ID: <87il8sv6r2.fsf@localhost> References: <87cyz6wtja.fsf.ref@yahoo.com> <87cyz6wtja.fsf@yahoo.com> <875y4xfl05.fsf@bernoul.li> <87ledthzzh.fsf@localhost> <878r9p1ntd.fsf@bernoul.li> <878r9phwsm.fsf@localhost> <877cp8bkpa.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19151"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 02 19:13:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcUBR-0004rR-62 for ged-emacs-devel@m.gmane-mx.org; Sat, 02 Sep 2023 19:13:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcUAZ-0006tr-S0; Sat, 02 Sep 2023 13:12:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcUAV-0006t4-03 for emacs-devel@gnu.org; Sat, 02 Sep 2023 13:12:19 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcUAR-00031I-Ub for emacs-devel@gnu.org; Sat, 02 Sep 2023 13:12:18 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 75735240103 for ; Sat, 2 Sep 2023 19:12:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693674733; bh=aRz88/xojJVs1hUSmEh44cy91dFV9g9DASWbFEvibd0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=Wastscu68rcz2W3VvqFvqYg/NgVu6QdOE4a2OqRO+EWvDvpeSrrWrPGRlVYX1rDNc eng8ru2E5P1VarcDmTSmoa1pp8gL/perr3jfbIZhJmlQGjcwKoMmNGMqPfp0KS5IGa KdiPP1hgSXk1IRp3F1TpTVqXOroodL3FHPOTJGjwjRQw90Zmj0fW03QyWbmkJ8Fo3Z mnJzW9dUFunm2X3SSgYlF52X3SR6nET9mkrVAIyoTqSZC5SgDCp8weneDHsOwRivp8 RVxqNojQiMS2dsfGVCHQLiIRQ0wYn53zPIyogXVEWlYo3sqrfz9G6FMTqLBWothgxZ Ofbfov34jGXKg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RdLzw6WkPz9rxK; Sat, 2 Sep 2023 19:12:12 +0200 (CEST) In-Reply-To: <877cp8bkpa.fsf@bernoul.li> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309900 Archived-At: Jonas Bernoulli writes: > Ihor Radchenko writes: > >>> Speaking of af9c063ed, that commit adds another regression and has >>> to be reverted. >> >> Maybe you mean some other commit? >> af9c063ed is just changing a docstring. > > Yes. It's e32bd5f7c78c9d92cefd9a78771f9729946fdf73. > > Instead of restoring the save-match-data, you could change the order > of the bindings. Oh. That's from the recent series of refactorings on main... That's my oversight - I misread the code to be `pcase', not `pcase-let*'. > When I wrote that function, I decided that I would rather use > save-match-data, even though that could be avoided. That way the two > bindings which set and then refine CMD based on the first submatch are > next to each other, and only after that has been taken care off, do we > move on to set ARGS based on the second submatch. But if you think it > is more important to avoid a save-match-data, or think the mistake you > made is likely to be repeated, I am fine with switching up the order. It is not super-important. I am just aiming to drop `save-match-data' where it is not necessary. But I am mostly focusing on performance-critical code, where is actually matters, reviewing all the uses along the way. Fixed, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=dbf415b84 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at