From: Philip Kaludercic <philipk@posteo.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: ELPA submission: plz-see
Date: Wed, 01 Nov 2023 09:14:01 +0000 [thread overview]
Message-ID: <87il6lu97q.fsf@posteo.net> (raw)
In-Reply-To: <87cywubl7g.fsf@gmail.com> (Augusto Stoffel's message of "Tue, 31 Oct 2023 21:17:39 +0100")
Augusto Stoffel <arstoffel@gmail.com> writes:
> Thanks for the comments!
>
> On Tue, 31 Oct 2023 at 08:43, Philip Kaludercic wrote:
>
>> +(eval-when-compile (require 'cl-lib))
>> (require 'json)
>
> By the way, the latter is kind of a non-essential require, would you
> rather write this near line 88?
>
> (defcustom plz-see-content-type-alist
> `(...
> ("\\`application/json" . ,(lambda ()
> (require 'json)
> (declare-function 'json-pretty-print-buffer "json.el")
> (json-pretty-print-buffer)
> (js-json-mode)))
> ...))
I don't have a strong opinion either way.
>> I agree, from what I see this is just an implementation detail. Plz is
>> a peculiar enough name as it is, it shouldn't be inherited by packages
>> that depend on it. Or is there any reason why the package couldn't also
>> use url.el?
>
> The packages is really closely tied to plz's API, which by the way is a
> very nice one.
But is this fact exposed to the user?
--
Philip Kaludercic
next prev parent reply other threads:[~2023-11-01 9:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 7:17 ELPA submission: plz-see Augusto Stoffel
2023-10-30 11:56 ` Eli Zaretskii
2023-10-31 8:09 ` Augusto Stoffel
2023-10-31 8:43 ` Philip Kaludercic
2023-10-31 20:17 ` Augusto Stoffel
2023-11-01 9:14 ` Philip Kaludercic [this message]
2023-11-01 18:36 ` Augusto Stoffel
2023-11-01 20:21 ` brickviking
2023-11-03 2:31 ` Richard Stallman
2023-11-03 6:32 ` brickviking
2023-11-03 7:50 ` Philip Kaludercic
2023-11-03 8:06 ` Eli Zaretskii
2023-11-03 14:46 ` Adam Porter
2023-11-04 1:10 ` Stefan Kangas
2023-11-04 2:10 ` Richard Stallman
2023-11-04 5:08 ` Adam Porter
2023-11-04 6:49 ` Eli Zaretskii
2023-11-04 8:51 ` tomas
2023-11-04 9:07 ` Eli Zaretskii
2023-11-04 9:34 ` tomas
2023-11-04 13:30 ` Adam Porter
2023-11-04 13:56 ` Eli Zaretskii
2023-11-04 14:38 ` Adam Porter
[not found] ` <877cmx4wgd.fsf@dick>
2023-11-04 13:37 ` tomas
[not found] ` <8734xlmwsm.fsf@dick>
2023-11-04 14:24 ` tomas
2023-11-04 10:38 ` Stefan Kangas
2023-11-04 12:28 ` Visuwesh
2023-11-04 13:17 ` tomas
2023-11-04 13:13 ` tomas
2023-11-04 6:47 ` Eli Zaretskii
2023-10-30 22:33 ` Stefan Kangas
2023-10-31 8:09 ` Augusto Stoffel
2023-11-01 0:37 ` Stefan Kangas
2023-11-01 7:29 ` Augusto Stoffel
2023-11-01 20:23 ` Stefan Kangas
2023-10-31 9:33 ` Mauro Aranda
2023-10-31 20:19 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il6lu97q.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).