From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Package suggestion[nongnu]: Gnosis =?utf-8?B?KM6zzr3hv7bPg865?= =?utf-8?B?z4Ip?= Date: Sat, 20 Jan 2024 12:20:42 +0000 Message-ID: <87il3o8acl.fsf@posteo.net> References: <87h6jdpts9.fsf@thanosapollo.org> <87h6jal96l.fsf@posteo.net> <87wms5fjjs.fsf@thanosapollo.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4932"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Thanos Apollo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 20 13:21:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rRALg-00016x-G7 for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Jan 2024 13:21:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rRALE-00077Y-Rq; Sat, 20 Jan 2024 07:20:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRALD-00076o-AO for emacs-devel@gnu.org; Sat, 20 Jan 2024 07:20:51 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rRAL9-0005bb-99 for emacs-devel@gnu.org; Sat, 20 Jan 2024 07:20:50 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BBA8F240103 for ; Sat, 20 Jan 2024 13:20:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705753243; bh=A5SsIJuuzr+RJe8K+cKKGW4Ta1agl+0esCRXHk/fHD8=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=PcebBDR/x2NjAXvf5rKY3e2KNIoYG7O+0zjErZGvJh9zKwPrFcPCqxwwzNCaGXMCr Z/Qnko+xsy7pE/t+MeyWwGyOCrViwuxVSi+PQ3P8uCVjnweLObGDZ33uqTokgR93IZ ckUQdPuklRK0wIue+4/s5SnGIlr1jvux2UGsEs3BEjxHXQ8/PKKag7ObXhjvxubXzL JrsKRSyOJU0RIH4K7K8FcWMnL4dS7oiKCJEzp/yW72Qx/mUXLGwZw1SU4YsmFR9KPg YM2KznBua+BP9rethjcK9TZmpSGEN0yYtaJHAyo5X2yiBdokRfE7/+eDng4QCbSrxo Qq9Y0GaJh7qQQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4THFtz1X4nz6tyG; Sat, 20 Jan 2024 13:20:43 +0100 (CET) In-Reply-To: <87wms5fjjs.fsf@thanosapollo.org> (Thanos Apollo's message of "Fri, 19 Jan 2024 16:45:35 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315142 Archived-At: Thanos Apollo writes: > Philip Kaludercic writes: >> >> Here area few comments in form of a diff (this is NOT a patch): > > [...] > > Thank you for your suggestions, they've been really helpful. > > I got confused and thought emacsql was included in nongnu elpa, but it's only > available only in nongnu-devel. You are right, that is peculiar. One should see what is holding back the release. > Is there any alternative that it's recommended instead of emacsql for a > package to interact with an sqlite databases? (Except triples) If you require at least Emacs 29, then you could fall back onto the built-in SQLite support. > I've refactored a couple important parts of gnosis to take into an > account future extensibility, even by 3rd party packages. Example: > > (defvar gnosis-note-types '(MCQ Cloze Basic Double y-or-n) > "Gnosis available note types.") > > (defun gnosis-add-note (type) > "Create note(s) as TYPE interactively." > (interactive (list (completing-read "Type: " gnosis-note-types nil t))) > (when gnosis-testing > (unless (y-or-n-p "You are using a testing environment! Continue?") > (error "Aborted"))) > (let ((func-name (intern (format "gnosis-add-note-%s" (downcase type))))) Perhaps using `intern-soft' would be better here. > (if (fboundp func-name) > (funcall func-name) > (message "No such type.")))) > > (defun gnosis-review-note (id) > "Start review for note with value of id ID." > (when (gnosis-suspended-p id) > (message "Suspended note with id: %s" id) > (sit-for 0.3)) ;; this should only occur in testing/dev cases > (let* ((type (gnosis-get 'type 'notes `(= id ,id))) > (func-name (intern (format "gnosis-review-%s" (downcase type))))) > (if (fboundp func-name) > (progn > (with-current-buffer (switch-to-buffer (get-buffer-create "*gnosis*")) You don't need `switch-to-buffer' if you are using `with-current-buffer'. > (gnosis-mode) > (funcall func-name id))) > (error "Malformed note type: '%s'" type)))) > > Adding new note types should be a trivial task now. > > I hadn't really used emacs without vertico and was unaware of how > different completing-read user interactions actually are. I will be > making adjustments for that wherever possible. I use Emacs that way, so if you have any questions I'd be glad to clarify usage patterns and annoyances.