From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jay Kamat Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 09:14:05 -0800 Message-ID: <87il29esj9.fsf@eve> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> <87ttltu939.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11845"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.13; emacs 28.2 Cc: Jeremy Bryant , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:30:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf1HV-0002rh-Ow for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:30:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf1Gr-0002yC-FU; Tue, 27 Feb 2024 12:29:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf14j-0003oB-6a for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:17:05 -0500 Original-Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rf14f-0000ET-Vj for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:17:04 -0500 Original-Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6e09143c7bdso2676316b3a.3 for ; Tue, 27 Feb 2024 09:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709054220; x=1709659020; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=uh2cDFDsjtQE4ujBplTkDXSl9tJ9Oi1vrye/3QGfMQ4=; b=ezvWJn4gtYw2IZ6OWm4Y5aw61/74wHTlFuiH7n+5B8eHJzWfKnprADtdmtCb+Uwdnk s2ZQpvc7rDNYkceS7GsBRZt7cOYg7DBv8v48T1wnBITfXCpw4B/oA4htvyIz5geCABGe 8f4DO+soo4AS8QEI+RLcbcmXLSxCrzydoYOsZ8aDYP+ZXy1B2OLQiExaJ9XVuoFrHaE8 vdMVxqejsamwbelQFqZ097Um3GadIizYdulIy4xD9fqaTiq6WlO7lmJYCyYBIteR16d1 c92pkkgs7JLdhLB7f0IkaqCm0lC3MhtswT3L+UkR76K0D6eQfKs2M1SUVo5//9Q85uFr zkwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709054220; x=1709659020; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uh2cDFDsjtQE4ujBplTkDXSl9tJ9Oi1vrye/3QGfMQ4=; b=qxmn7IuDkowDTs8MF4B8PHCwv7J9R+kjy1Vr3bh1JHX/kq3qWcWtCKkzl6noMcEdQJ xicln8rLl1REkOTPukSURXdXUQ8dfrmCGWus6Rz9Tzqe62mDtetIfZ0Ej+c8JoM+ZDmW 1dguo6ErbesuKaW6VH42yqKR4UPs3ALFxXSIvJ0wcfvhEJ8mamDR4/W7y30l5luXrAlw Qe7h1uaytl4DfNPVpL0Fxc1Padp/NdWjcTXqfmbaz01F6t+3V4YXQVtJmqGJHibkxIQX /rt6tishsF+44ZQMJdXxtdUEoFN8TdBA9kv493ISthrKAekolcfS70OJs3STe1uPNOJh gn0A== X-Forwarded-Encrypted: i=1; AJvYcCVPN91rT60m5DKPmCi55RU8w9unZUGMH9vynLC2XJV0Y4BR8bpx/GW4TmTiBPNnoqciuseenm8JPs963lgOF+Mpkl9O X-Gm-Message-State: AOJu0Ywb5Zu9kLBNwsVZxRrMF78WB5N7I2pcjQAVBuJq4dUGhqkOLDms TUsUZM4RvRfDEmxmrXz+FTC2dVi1d0H/kGldz97KnbScdoG/fShm X-Google-Smtp-Source: AGHT+IEEwrZOfKIZ3ZeE35RxsQEpTX6nuPQt8A6AL6yYevoJlj8+H9pVqAEysFIJs9i5BIQGwcl8PA== X-Received: by 2002:a05:6a20:9f4e:b0:1a0:e187:81b8 with SMTP id ml14-20020a056a209f4e00b001a0e18781b8mr2751728pzb.45.1709054220210; Tue, 27 Feb 2024 09:17:00 -0800 (PST) Original-Received: from eve (c-98-207-12-150.hsd1.ca.comcast.net. [98.207.12.150]) by smtp.gmail.com with ESMTPSA id p30-20020aa79e9e000000b006e509762bc2sm4784557pfq.26.2024.02.27.09.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:16:59 -0800 (PST) In-reply-to: <87ttltu939.fsf@posteo.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=jaygkamat@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 27 Feb 2024 12:29:36 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316597 Archived-At: Philip Kaludercic writes: > Jay Kamat writes: > >> Philip Kaludercic writes: >> >> Might take me a while to fully review and test all the changes, but >> they look good, so once I do so, I'll include them! >> >>> +(defcustom rmsbolt-mode-lighter " RMS=F0=9F=97=B2" ;could the unicode >>> charachter be removed? it can unnecessarily resize the mode line. >> >> Sure - I can remove it. I'll do it after I apply your patch generally. > > Just keep in mind that I didn't send a patch. I just find it convenient > to send comments in form of a diff. Ah - I didn't realize. I think most of your code-changes are good, is it=20 alright if I apply them? I'll make a commit with you as the author (or I ca= n=20 take authorship/not commit them - whatever your preference is). >>> >>> ;;;;; Starter Definitions >>> >>> ;; IIUC, this "starter" business is not a necessary part of RMSBolt, b= ut=20 >>> is >>> ;; a way to provide sample files with which users can try out RMSBolt. >>> >>> -(defvar rmsbolt-starter-files >>> +(defvar rmsbolt-starter-files ;should this be part >>> of a secondary file that isn't loaded by default? >> >> Maybe - I think I would load it by default though - as this is the >> easiest way for someone to try out the package. In my personal usage I >> almost always start from one of these files and add my changes. I >> should update the comment above with that information as well. > > It shouldn't matter, as long as the command that uses > `rmsbolt-starter-files' remains auto-loaded, even if the command is > not defined in the main file. Ah - that's true! I'll try to make this change after the others if I have=20 time. Thanks again for taking a look! -Jay