From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Re: TAGS completion with (setq-local completion-ignore-case t) Date: Sat, 09 Mar 2024 13:23:08 +0000 Message-ID: <87il1vk08z.fsf@ice9.digital> References: <87frx2qu8z.fsf@ice9.digital> <868r2u2x4u.fsf@gnu.org> <87bk7qqsdk.fsf@ice9.digital> <865xxy2u6y.fsf@gnu.org> <877cieqnm0.fsf@ice9.digital> <8634szzvtv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15854"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 09 14:23:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riwfw-0003uP-I3 for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Mar 2024 14:23:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1riwfX-0001X1-03; Sat, 09 Mar 2024 08:23:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riwfV-0001Wt-9I for emacs-devel@gnu.org; Sat, 09 Mar 2024 08:23:17 -0500 Original-Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riwfS-0001Wq-LH; Sat, 09 Mar 2024 08:23:16 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8AFC720004; Sat, 9 Mar 2024 13:23:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1709990589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HbOOyEUEuX+cB1zKKMK3B7sgr8EDGK0ApVJfPak5Yz8=; b=R2evIOSYrW8+gjfr0clyh54qZmlHtWrC85pfEEwcO6HUv1+uuuafbhxGAdKTNnwqIY5ncH MiUg66s4OHxA21OBd9xr+INWMcayRE+TeNO9JcssIGkrC11JNcX5dgcrBQ5aVy8UUZ9cWP pSVsrjlQ2BUrGQ4rdRnx4qMbMkQuKJohhLLTZhEbgppYdCgrcyHX/K4pWezpppXZc4CkPR P7qcmY9Un95SJfzbJkozU9AbYgnMHx5OMNXI2FK2dpahRCoA7vXyPSdfXQc2oJKxIGBkQB HJKrSiLv1kL8NUnEMX8J2cVwSkoT/5i64ubxWVVb98y2KoaettqzVl7/82Hvmg== In-Reply-To: <8634szzvtv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Mar 2024 09:51:56 +0200") X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=morgan@ice9.digital; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316943 Archived-At: Eli Zaretskii writes: > Does the patch below give good results? > > diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el > index 476037e..5976121 100644 > --- a/lisp/progmodes/etags.el > +++ b/lisp/progmodes/etags.el > @@ -2065,7 +2065,8 @@ complete-tag > (user-error "%s" > (substitute-command-keys > "No tags table loaded; try \\[visit-tags-table]"))) > - (let ((comp-data (tags-completion-at-point-function))) > + (let ((comp-data (tags-completion-at-point-function)) > + (completion-ignore-case (find-tag--completion-ignore-case))) > (if (null comp-data) > (user-error "Nothing to complete") > (completion-in-region (car comp-data) (cadr comp-data) I rebuilt from the latest commit on the master branch to incorporate the patch. Unfortunately, I do not see any change in the result of the failing test case; the completion still appears to be case-sensitive. printf "Function IsSingle\nFunction IsString\n" > functions etags --lang=none --regex='/^function[ \t]+\([0-9A-Za-z:_]+\)/\1/i' functions emacs -Q --eval "(progn \ (pop-to-buffer (get-buffer-create \"test\")) \ (setq-local completion-ignore-case t) \ (visit-tags-table \"TAGS\") \ (insert \"is\") \ (complete-tag) \ (complete-tag))" # No completions. -- Morgan Willcock