From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: master 08c80c45dde: Don't use file-truepath in Eglot (bug#70036) Date: Wed, 17 Apr 2024 20:41:41 +0200 Message-ID: <87il0fsufu.fsf@thornhill.no> References: <171215083924.12380.5369373861551158668@vcs2.savannah.gnu.org> <20240403132719.A18EFC12C28@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9733"; mail-complaints-to="usenet@ciao.gmane.io" To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 17 20:42:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxAEe-0002NO-1b for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Apr 2024 20:42:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxAEC-0006DN-7Z; Wed, 17 Apr 2024 14:41:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxAEA-00069p-GA for emacs-devel@gnu.org; Wed, 17 Apr 2024 14:41:50 -0400 Original-Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxAE7-0005yp-2Y for emacs-devel@gnu.org; Wed, 17 Apr 2024 14:41:50 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1713379303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GU9XnTqpVnFnOCLKoEdOXx43ZM9CGuiWzGfYLkRfoNE=; b=qsFjAZNh618/BbGcWk08fPht8bbV11BVc94VhAxn7RtGp0xvN5jfYdP5I1WD+TpXK3wSAH RTKszYScPc5hN5VO50Gdijg+7qsOTmefkMBwY36mD8HqPtjdBPQpolLGHeVhX7uVt/Gxlb Zs1ZoTI7cklxmWX1bSQy9+znKnRsNp2XnkPmelTryRTEb+JxsYnJtnI87iYIJCAwmyCrf7 vmsMJZE3j+5qHpms4q7VorejUe5Y0hIZnHuyPmusZeZ4QCJ/7J0uPvQEh+rQs7Eta8etbZ /8niskcyXNkvPa03zrucVZe3H1v0ZyViKheZZweFipedJrIMbZ0wevjCJoFygw== In-Reply-To: X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::ab; envelope-from=theo@thornhill.no; helo=out-171.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317783 Archived-At: > Hey Theo, > Hey! > I don't disagree strongly with these changes (*), but was surprised > to find them pushed without asking me specifically about this patch. > It's true you CCed me about the need for file-truename and I didn't > reply. But still, another email with the patch about to be pushed > would have been nice. Sure thing - I'll consider this next time. I did mention it in the bug report, but could have been more clear, absolutely. > > I have been looking for an Eglot maintainer but everyone I contacted > said no, so I assume I'm still the maintainer. This is in contrast > to Flymake and Jsonrpc where I've found two people willing to take it > up. > > I still get some email and GitHub traffic about Eglot. I'd very much > like to hand it over to you guys formally, I think you, Felici=C3=A1n, > Stefan, and others will do a fine job, collectively. Even if I would > prefer to hand it over to someone with some kind of vision for it > (but hey beggars can't be choosers). > > I'd also like to be a "whole-package situation", where you guys also > watch over the downstream GitHub repo (or convert it or phase it out > or whatever) so I can unsubscribe in peace. If you want I can do this - so that you don't have to. I've been considering it for some time after I responded to your call for maintainers. > > Just now I got this report in the GitHub tracker about Eglot > spamming *Messages* https://github.com/joaotavora/eglot/discussions/1389 > and was caught a bit off-guard, as I had nothing to do with it. > ;-) > So I propose that as long as you and others (legitimately, of course) > decline the "whole package" offer, you keep giving me just a tiny bit of = heads > up about what's being proposed to the code (beside the trivial "add > support for XYZ server" of course). Or if you prefer just _inform_ me > that this or that change was pushed recently, so I can comment back > while the matter is still fresh. > > Felici=C3=A1n did this just today with a patch proposal. > Sure > Thanks. And thanks for your work on Eglot, of course. > Jo=C3=A3o > > > (*) As to the actual change... > > On Wed, Apr 3, 2024 at 2:27=E2=80=AFPM Theodor Thornhill via Mailing list= for > Emacs changes wrote: > >> the implementation to a hash map will yield similar performance >> benefits, but wouldn't require us to rewrite `file-truename' in C. > > > The change seems well structured, well coded, and well described in the > commit message, so I could understand it easily. Do keep that up. > > But of course going from file-buffer-visiting to something else > whose underlying implementation is faster but doesn't chase > symlinks is probably going to have some kind of functional implication > right? I wonder if (or rather "I hope that") you guys considered it. I did - and afaict it has no such implications. It > Also, when using a cache to solve a problem, remember cache invalidation > is one of the 2 hard ones ;-) Sure this cache won't ever need > invalidation? Even when the user moves file around during an Eglot > session? The cache cleans itself up - when a buffer is deleted or the minor mode shut off. Eglot before this change was basically the same, except it kept buffers in a list rather than a lookup map. The change is mostly a complexity improvement, with the added benefit that we don't have to rely on file-truename. > > If you ask me, this 'rewrite `file-truename' in C.' is what should be > done. No idea how hard that is, but a hash table just isn't fit to answ= er the > same questions as 'find-buffer-visiting'. That's right, and to some extent I agree. However, find-buffer-visiting isn't really what's needed in this case, at least from what I can see. I'm still considering rewriting it in C, but I didn't get to this yet. Theo