From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New package org-transclusion-http Date: Sat, 15 Jun 2024 11:46:34 -0700 Message-ID: <87ikyaniwl.fsf@ushin.org> References: <87sezvt2rc.fsf@ushin.org> <87tti2u8jx.fsf@ushin.org> <87o782mje9.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel Mailing List , me@nobiot.com To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 15 20:56:55 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIYa6-0003Cg-KS for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Jun 2024 20:56:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIYZd-0001Ou-U5; Sat, 15 Jun 2024 14:56:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIYQG-0006ny-4Z for emacs-devel@gnu.org; Sat, 15 Jun 2024 14:46:44 -0400 Original-Received: from out-184.mta0.migadu.com ([91.218.175.184]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIYQD-0005Bz-Kg for emacs-devel@gnu.org; Sat, 15 Jun 2024 14:46:43 -0400 X-Envelope-To: philipk@posteo.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ushin.org; s=key1; t=1718477199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YDTTbkTUfMr+HlpTn4SR5q/+FrjCkdjOvmhkMZ+BUk0=; b=NjVfLw31Jr29PFr21tOHkKBj7R7bxvuG2Q3JlnGescJaf8ztxc+/aXVVR/VMw2bK2gGBaA Qe6u/lglw+P5vS2tuQ90wEU1w4wwsGyuT57T2CmaD01hPHxYbK6NT0FYLglZAP093/qd6y iIyrw+vH/hk45XLS55uUX9BmEYGN72t+okBAmrN8CNElJa2M6SYsPhE44+LWt/JH+9bHDc /BN9857oJBXVCB6locja/zs+gg0PGEhI9ri2IBkzpP+l1ZdYz6vZNOD43Q48rstimZpfqA o71QmxK6ew7xslHzr7Wm91tx3pSfi9p1dmcpo7vfvyFXUtbQoHpNuLZhoPlxjw== X-Envelope-To: emacs-devel@gnu.org X-Envelope-To: me@nobiot.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <87o782mje9.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 15 Jun 2024 13:21:18 +0000") X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.184; envelope-from=joseph@ushin.org; helo=out-184.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 15 Jun 2024 14:56:24 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320166 Archived-At: Thank you for the review! Philip Kaludercic writes: > There is really not much I can comment on, since it is mainly API I am > not familiar with. One note is that the package description doesn't > make much sense to me, since I don't know what "transcluding" means. > Also, not everyone knows that "plz" is a HTTP library (the name remains > elusive), so a brief comment reminding the reader of that would be > appropriate. I've updated the package description. > Another note is that if you already have a .dir-locals.el file, you > could add a few more variables that might vary from system to system. > In Compat, the .dir-locals.el lists: > > --8<---------------cut here---------------start------------->8--- > ((nil > (fill-column . 72) > (sentence-end-double-space . t) > (show-trailing-whitespace . t) > (indent-tabs-mode . nil))) > --8<---------------cut here---------------end--------------->8--- I've added all these variables except show-trailing-whitespace, as I don't personally use it. ws-butler takes care of whitespace without adding visuals. > Also, I think an .elpaigore file would be appropriate to have in the > repo, at least to avoid bundling the build-time dependencies. I've added .elpaignore and pushed a new release v0.3. Thank you!!! Joseph