From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-30 ab7c40ea52a: Fix Imenu in 'emacs-news-view-mode'
Date: Tue, 23 Jul 2024 14:42:47 +0200 [thread overview]
Message-ID: <87ikww9t4o.fsf@gmail.com> (raw)
In-Reply-To: <86y15ta8za.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Jul 2024 15:48:09 +0300")
>>>>> On Mon, 22 Jul 2024 15:48:09 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Mon, 22 Jul 2024 14:36:55 +0200
>>
>> Should `emacs-news-view-mode' still have bindings for the
>> `emacs-news-mode' commands that change the buffer?
Eli> No.
Done.
>> Theyʼd all fail because of the read-only buffer, but we could remove
>> them. (hmm, the menus are wrong for `emacs-news-view-mode'
>> anyway. Iʼll fix that as well).
Done in de9f9add138
The only difference in key-bindings between `emacs-news-mode' and
`emacs-news-view-mode' are the buffer editing commands and the
special mode commands (and `emacs-news-view-mode' has a menu without
the editing commands).
Robert
--
prev parent reply other threads:[~2024-07-23 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172146804439.2058.3466869777211222963@vcs2.savannah.gnu.org>
[not found] ` <20240720093404.DAF02C41F01@vcs2.savannah.gnu.org>
2024-07-22 11:19 ` emacs-30 ab7c40ea52a: Fix Imenu in 'emacs-news-view-mode' Robert Pluim
2024-07-22 11:39 ` Eli Zaretskii
2024-07-22 12:36 ` Robert Pluim
2024-07-22 12:48 ` Eli Zaretskii
2024-07-23 12:42 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikww9t4o.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).