* Where to send patches for ELPA packages
@ 2024-07-28 13:03 Xiyue Deng
2024-07-28 17:05 ` Emanuel Berg
2024-07-28 21:32 ` Philip Kaludercic
0 siblings, 2 replies; 6+ messages in thread
From: Xiyue Deng @ 2024-07-28 13:03 UTC (permalink / raw)
To: Emacs developers
Hi,
I have been working on getting oauth2.el to work and have a few patches
that I think may improve its usability. I'm aware of `send-emacs-bug',
but wondering whether that is the correct place to send patches for ELPA
packages? Or is there another place for patches for ELPA packages?
Thanks in advance.
--
Xiyue Deng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Where to send patches for ELPA packages
2024-07-28 13:03 Where to send patches for ELPA packages Xiyue Deng
@ 2024-07-28 17:05 ` Emanuel Berg
2024-07-28 19:34 ` Xiyue Deng
2024-07-28 21:32 ` Philip Kaludercic
1 sibling, 1 reply; 6+ messages in thread
From: Emanuel Berg @ 2024-07-28 17:05 UTC (permalink / raw)
To: emacs-devel
Xiyue Deng wrote:
> I have been working on getting oauth2.el to work and have
> a few patches that I think may improve its usability.
> I'm aware of `send-emacs-bug', but wondering whether that is
> the correct place to send patches for ELPA packages? Or is
> there another place for patches for ELPA packages?
Good work and good question, how about mailing the maintainer,
maybe he will grant you access so you can do it with you own
tools, but if that isn't possible or just overkill for the
purpose maybe you just mail the patch to him?
But you will have to wait for an authoritative answer this
quiet Sunday.
--
underground experts united
https://dataswamp.org/~incal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Where to send patches for ELPA packages
2024-07-28 17:05 ` Emanuel Berg
@ 2024-07-28 19:34 ` Xiyue Deng
0 siblings, 0 replies; 6+ messages in thread
From: Xiyue Deng @ 2024-07-28 19:34 UTC (permalink / raw)
To: emacs-devel
Hi Emanuel,
Emanuel Berg <incal@dataswamp.org> writes:
> Xiyue Deng wrote:
>
>> I have been working on getting oauth2.el to work and have
>> a few patches that I think may improve its usability.
>> I'm aware of `send-emacs-bug', but wondering whether that is
>> the correct place to send patches for ELPA packages? Or is
>> there another place for patches for ELPA packages?
>
> Good work and good question, how about mailing the maintainer,
> maybe he will grant you access so you can do it with you own
> tools, but if that isn't possible or just overkill for the
> purpose maybe you just mail the patch to him?
Good idea! Let me mail the patches to the maintainer.
>
> But you will have to wait for an authoritative answer this
> quiet Sunday.
Sure! Will also wait here while waiting for the maintainer's response.
--
Xiyue Deng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Where to send patches for ELPA packages
2024-07-28 13:03 Where to send patches for ELPA packages Xiyue Deng
2024-07-28 17:05 ` Emanuel Berg
@ 2024-07-28 21:32 ` Philip Kaludercic
2024-07-28 22:20 ` Xiyue Deng
1 sibling, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2024-07-28 21:32 UTC (permalink / raw)
To: Xiyue Deng; +Cc: Emacs developers
Xiyue Deng <manphiz@gmail.com> writes:
> Hi,
>
> I have been working on getting oauth2.el to work and have a few patches
> that I think may improve its usability. I'm aware of `send-emacs-bug',
> but wondering whether that is the correct place to send patches for ELPA
> packages? Or is there another place for patches for ELPA packages?
If you use package-vc, there is also `package-vc-prepare-patch', but
that just uses the "Maintainer" address. If the maintainer doesn't
respond, you can send the patches to this mailing list and they can be
pushed to elpa.git. Note that this is a lot easier of the package is
developed in elpa.git, not mirrored from some remote repository.
> Thanks in advance.
--
Philip Kaludercic on peregrine
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Where to send patches for ELPA packages
2024-07-28 21:32 ` Philip Kaludercic
@ 2024-07-28 22:20 ` Xiyue Deng
2024-07-30 8:37 ` Xiyue Deng
0 siblings, 1 reply; 6+ messages in thread
From: Xiyue Deng @ 2024-07-28 22:20 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: Emacs developers
Hi Philip,
Philip Kaludercic <philipk@posteo.net> writes:
> Xiyue Deng <manphiz@gmail.com> writes:
>
>> Hi,
>>
>> I have been working on getting oauth2.el to work and have a few patches
>> that I think may improve its usability. I'm aware of `send-emacs-bug',
>> but wondering whether that is the correct place to send patches for ELPA
>> packages? Or is there another place for patches for ELPA packages?
>
> If you use package-vc, there is also `package-vc-prepare-patch', but
> that just uses the "Maintainer" address. If the maintainer doesn't
> respond, you can send the patches to this mailing list and they can be
> pushed to elpa.git. Note that this is a lot easier of the package is
> developed in elpa.git, not mirrored from some remote repository.
>
Thanks for the suggestions! I have followed Emanuel's suggestion and
mailed the packages to the maintainer. If I don't hear back in a few
days I'll forward the patches here.
>> Thanks in advance.
--
Xiyue Deng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Where to send patches for ELPA packages
2024-07-28 22:20 ` Xiyue Deng
@ 2024-07-30 8:37 ` Xiyue Deng
0 siblings, 0 replies; 6+ messages in thread
From: Xiyue Deng @ 2024-07-30 8:37 UTC (permalink / raw)
To: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]
Xiyue Deng <manphiz@gmail.com> writes:
> Hi Philip,
>
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Xiyue Deng <manphiz@gmail.com> writes:
>>
>>> Hi,
>>>
>>> I have been working on getting oauth2.el to work and have a few patches
>>> that I think may improve its usability. I'm aware of `send-emacs-bug',
>>> but wondering whether that is the correct place to send patches for ELPA
>>> packages? Or is there another place for patches for ELPA packages?
>>
>> If you use package-vc, there is also `package-vc-prepare-patch', but
>> that just uses the "Maintainer" address. If the maintainer doesn't
>> respond, you can send the patches to this mailing list and they can be
>> pushed to elpa.git. Note that this is a lot easier of the package is
>> developed in elpa.git, not mirrored from some remote repository.
>>
>
> Thanks for the suggestions! I have followed Emanuel's suggestion and
> mailed the packages to the maintainer. If I don't hear back in a few
> days I'll forward the patches here.
>
FYI Julien replied to my inquiry that he is no longer an active
maintainer, and suggested me to post the patch to the mailing list.
Instead, I filed a bug for it at bug#72358[1], where I have already got
a review (thanks Robert!). Please feel free to comment there.
Thanks!
>>> Thanks in advance.
[1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2024-07/msg01305.html
--
Xiyue Deng
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-30 8:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-28 13:03 Where to send patches for ELPA packages Xiyue Deng
2024-07-28 17:05 ` Emanuel Berg
2024-07-28 19:34 ` Xiyue Deng
2024-07-28 21:32 ` Philip Kaludercic
2024-07-28 22:20 ` Xiyue Deng
2024-07-30 8:37 ` Xiyue Deng
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).