From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand Date: Tue, 03 Dec 2024 09:19:46 +0100 Message-ID: <87iks118m5.fsf@gmx.de> References: <173314163483.652988.2881826266893472321@vcs3.savannah.gnu.org> <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stephen Berman To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 09:20:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIO8i-0003XK-AB for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 09:20:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIO8S-0006DS-8s; Tue, 03 Dec 2024 03:19:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIO8Q-0006D0-E2 for emacs-devel@gnu.org; Tue, 03 Dec 2024 03:19:54 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIO8O-0001q6-49 for emacs-devel@gnu.org; Tue, 03 Dec 2024 03:19:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1733213987; x=1733818787; i=michael.albinus@gmx.de; bh=4biq5kumjABlDpfcm+z78vOwcHz/5Q0FPbY9DhTtpeQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=nVa5RVtwpGA6wgD+KHBtieT1GtCHnMWWW6wrZ3vVGx+BDYYeiSx+XZULHn3dnZl0 BbL3hAOAJFejcMJB/HJRv0JzgOJPmip3OvPMsP+QlHDSTUKt5kknLLiUp4ZZeSHLk wzDN4dB3Bh9tAMslBUPy3/4j930UA3xOu5A3OUyENA2dln7eOxmoik/a9T/+OEaA/ KODAwdHe3uFing9/BydzbWrCp+IC5DZa0krOezlM0FC6rCkPG7je8QnCoDczcxaOB y9gzXN8/NELrKSj2uE33WwLujNTe21z/iXG4ZlKeayclT7+GDOCGidQbpUgwivFM7 LiqrdAv+YFymGTU+uw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mo6ux-1u26sT4A2t-00emwq; Tue, 03 Dec 2024 09:19:47 +0100 In-Reply-To: <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org> (Stephen Berman via Mailing list for Emacs changes's message of "Mon, 2 Dec 2024 07:13:55 -0500 (EST)") X-Provags-ID: V03:K1:scLODjrLkVzDcSFA853vTDBdVRBTe/IEfXnhNTbrb8L8KkyxYQW vcH4mlC0Bdn2rBd2JtO0z5e6lotr2CLsLBZr/Qk2knEayQHNGkxSHjI3q65Ia4GASrVsPvT j3jSsbh4ExT+dsZVrDIRIh2FQgJe1ORGRXrwpmJVN345HKqbFs5VWeTfF1e6BQOAVIX7cWV Ui2KpRgdy4k3Oh1qpnK8Q== UI-OutboundReport: notjunk:1;M01:P0:EtNpGQt24yk=;ButXVHaI4z2hvWtO2WKcSxAsDfp k5OqMyBeB7WH6HlV9tVv7jiqg+Ta+i2yEJOhz4OHPiBbUk4vjdiPBIyRJp85iiyTFXQrUxgx/ fO0VhVtyRYyLZUu0uI76Ypdy/WZcnrEuG+1VmbtLwZ+ojEEAeI+ZztKKgjNmHtE6NUCG2JrAm US6q8VxHeH0JjRIimXGWB/34jnu2J+JE7GEI1F0g7qKxeHUA3IT1ZccMVV5ORAFXfzQJY7blJ +X1DTro9sn6n1T4BLLX7tlESNPUgIC+yzq+dEyT3KM7F5zRzc5YwSZ09dqwZkH50C6v6OI29m VfE27vSWNlnXO7xLias9+VezPGz2Nji+6ZTmMaGsAcD7S/+Q3mlzAn4EH+wVinmbYYllwtU+i zhC19ne0NhxZLN58ns58fBpafZxgyb10YfrSib2RIg02L8xL4Bnn5/xQ/WKr/4f/tgbWQQcKZ rkxI4MD5h8eLrCM2tDqp8FvD21KL4dV8IdzVSQHFLL4NfHM2dg2bfpYrJwkurauHPMEkc4oCo WxsNtnoD5JWfAjYj2fxClvcadcO5x84PhD4+ImGMHtfKWh3u7A4JB0w1Py+LRBO86xQOsRSss nvZlcwDWb1PaXrRUNSJCmw9s2O+zKQ6IHqobZi2dNrRgHgjhzoOk3HtAoAYSp6JXMi3csa9Dl 1p1QcBal6QPVl6VT+lC1lI62ZHoNrOV0a5FisgeAplcpgBPAYzcCVVEeaulc24CIL4C9fI6NI SYW0lhaYmjbTYu+y0mAGqx9LSy+eizdxlEXx0khJzx92d3muAbfbuJGEjH7U3Cm1+KGfc0S9 Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325974 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stephen Berman via Mailing list for Emacs changes writes: Hi Stephen, > branch: emacs-30 > commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d > Author: Stephen Berman > Commit: Stephen Berman > > Fix latest test for dabbrev-expand > > * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer): > Fix typo in a 'should' test, use part of return value of 'should-err= or' > test, and remove mistaken and unfounded FIXME comment. > --- > test/lisp/dabbrev-tests.el | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) I'm not sure whether it was this commit, or a previous one. But dabbrev-tests.el is broken in the emacs-30 branch. Running 'make -C test dabbrev-tests.log' yields the appended log file. Best regards, Michael. --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename=dabbrev-tests.log Content-Transfer-Encoding: quoted-printable Running 16 tests (2024-12-03 09:13:26+0100, selector `(not (tag :unstable))= ') Scanning for dabbrevs...=20 Scanning for dabbrevs...done passed 1/16 dabbrev-completion-test (0.000245 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Scanning for dabbrevs...done Making completion list... passed 2/16 dabbrev-completion-test-with-argument (0.016201 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `*Completions*' Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `foo' Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Test dabbrev-expand-after-killing-buffer backtrace: signal(ert-test-failed (((should (string=3D msg "No further dynamic ex ert-fail(((should (string=3D msg "No further dynamic expansion for =E2=80= =98ab (if (unwind-protect (setq value-179 (apply fn-177 args-178)) (setq f (let (form-description-181) (if (unwind-protect (setq value-179 (app (let ((value-179 'ert-form-evaluation-aborted-180)) (let (form-descr (let* ((fn-177 #'string=3D) (args-178 (condition-case err (list msg "N (let ((msg (car (cdr (let* ((fn-165 ...) (args-166 ...)) (let (...)=20 (progn (save-current-buffer (set-buffer (get-buffer-create "foo")) ( (unwind-protect (progn (save-current-buffer (set-buffer (get-buffer- (let* ((abbreviated-home-dir nil) (process-environment (cons (format (progn (let* ((abbreviated-home-dir nil) (process-environment (cons=20 (unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct #f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name dabbrev-expand-after-killing-buffer : ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l command-line() normal-top-level() Test dabbrev-expand-after-killing-buffer condition: (ert-test-failed ((should (string=3D msg "No further dynamic expansion for =E2=80=98ab= =E2=80=99 found")) :form (string=3D "No further dynamic expansion for `ab' found" "No further dynamic expansion for =E2=80=98ab=E2=80=99 found") :value nil :explanation (array-elt 33 (different-atoms (96 "#x60" "?`") (8216 "#x2018" "?=E2=80=98"))))) FAILED 3/16 dabbrev-expand-after-killing-buffer (0.005580 sec) at lis= p/dabbrev-tests.el:278 passed 4/16 dabbrev-expand-test (0.000275 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 5/16 dabbrev-expand-test-minibuffer-1 (0.267578 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 6/16 dabbrev-expand-test-minibuffer-2 (0.308566 sec) Scanning for dabbrevs...99%=20 Scanning for dabbrevs...done Expansion found in `dabbrev-expand.el' Scanning for dabbrevs...99%=20 Scanning for dabbrevs...done Expansion found in `dabbrev-expand.el' Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' Scanning for dabbrevs...99%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 7/16 dabbrev-expand-test-minibuffer-3 (0.562288 sec) I-search: I I-search: In I-search: Ind Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 8/16 dabbrev-expand-test-minibuffer-4 (0.278303 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 9/16 dabbrev-expand-test-other-buffer-1 (0.274776 sec) Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Expansion found in `INSTALL_BEGIN' passed 10/16 dabbrev-expand-test-other-buffer-2 (0.300569 sec) Scanning for dabbrevs...99%=20 Scanning for dabbrevs...done Expansion found in `dabbrev-expand.el' Scanning for dabbrevs...99%=20 Scanning for dabbrevs...done Expansion found in `dabbrev-expand.el' Scanning for dabbrevs...done Expansion found in `dabbrev-tests.el' Test dabbrev-expand-test-other-buffer-3 backtrace: signal(ert-test-failed (((should (string=3D (buffer-string) "Indic and ert-fail(((should (string=3D (buffer-string) "Indic and")) :form (stri (if (unwind-protect (setq value-92 (apply fn-90 args-91)) (setq form (let (form-description-94) (if (unwind-protect (setq value-92 (apply (let ((value-92 'ert-form-evaluation-aborted-93)) (let (form-descrip (let* ((fn-90 #'string=3D) (args-91 (condition-case err (list (buffer- (progn (find-file (expand-file-name "INSTALL_BEGIN" (let* ((testfile (unwind-protect (progn (find-file (expand-file-name "INSTALL_BEGIN"=20 (let* ((abbreviated-home-dir nil) (process-environment (cons (format (progn (let* ((abbreviated-home-dir nil) (process-environment (cons=20 (unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct #f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name dabbrev-expand-test-other-buffer-3 :d ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l command-line() normal-top-level() Test dabbrev-expand-test-other-buffer-3 condition: (ert-test-failed ((should (string=3D (buffer-string) "Indic and")) :form (string=3D "Indic\")) (execute-kbd-macro" "Indic and") :value nil :explanation (arrays-of-different-length 27 9 "Indic\")) (execute-kbd-macro" "Indic and" first-mismatch-at 5))) FAILED 11/16 dabbrev-expand-test-other-buffer-3 (0.561430 sec) at lisp= /dabbrev-tests.el:175 I-search: I I-search: In I-search: Ind Scanning for dabbrevs...100%=20 Scanning for dabbrevs...done Test dabbrev-expand-test-other-buffer-4 backtrace: user-error("No%s dynamic expansion for `%s' found" "" "execute-kbd-m dabbrev-expand(nil) funcall-interactively(dabbrev-expand nil) command-execute(dabbrev-expand) execute-kbd-macro([73 110 100 134217775]) (let (disabled-command-function) (find-file (expand-file-name "INSTA (progn (let (disabled-command-function) (find-file (expand-file-name (unwind-protect (progn (let (disabled-command-function) (find-file ( (let* ((abbreviated-home-dir nil) (process-environment (cons (format (progn (let* ((abbreviated-home-dir nil) (process-environment (cons=20 (unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct #f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name dabbrev-expand-test-other-buffer-4 :d ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l command-line() normal-top-level() Test dabbrev-expand-test-other-buffer-4 condition: (user-error "No dynamic expansion for `execute-kbd-macroInd' found") FAILED 12/16 dabbrev-expand-test-other-buffer-4 (0.291485 sec) at lisp= /dabbrev-tests.el:194 passed 13/16 dabbrev-expand-test-same-buffer-1 (0.297619 sec) passed 14/16 dabbrev-expand-test-same-buffer-2 (0.290400 sec) passed 15/16 dabbrev-expand-test-same-buffer-3 (0.271752 sec) I-search: I I-search: In I-search: Ind passed 16/16 dabbrev-expand-test-same-buffer-4 (0.283636 sec) Ran 16 tests, 13 results as expected, 3 unexpected (2024-12-03 09:13:32+010= 0, 5.467870 sec) 3 unexpected results: FAILED dabbrev-expand-after-killing-buffer FAILED dabbrev-expand-test-other-buffer-3 FAILED dabbrev-expand-test-other-buffer-4 --=-=-=--