From: Michael Albinus <michael.albinus@gmx.de>
To: emacs-devel@gnu.org
Cc: Stephen Berman <stephen.berman@gmx.net>
Subject: Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand
Date: Tue, 03 Dec 2024 09:19:46 +0100 [thread overview]
Message-ID: <87iks118m5.fsf@gmx.de> (raw)
In-Reply-To: <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org> (Stephen Berman via Mailing list for Emacs changes's message of "Mon, 2 Dec 2024 07:13:55 -0500 (EST)")
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Stephen Berman via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
Hi Stephen,
> branch: emacs-30
> commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d
> Author: Stephen Berman <stephen.berman@gmx.net>
> Commit: Stephen Berman <stephen.berman@gmx.net>
>
> Fix latest test for dabbrev-expand
>
> * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer):
> Fix typo in a 'should' test, use part of return value of 'should-error'
> test, and remove mistaken and unfounded FIXME comment.
> ---
> test/lisp/dabbrev-tests.el | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
I'm not sure whether it was this commit, or a previous one. But
dabbrev-tests.el is broken in the emacs-30 branch. Running 'make -C test
dabbrev-tests.log' yields the appended log file.
Best regards, Michael.
[-- Attachment #2: dabbrev-tests.log --]
[-- Type: text/plain, Size: 9151 bytes --]
Running 16 tests (2024-12-03 09:13:26+0100, selector `(not (tag :unstable))')
Scanning for dabbrevs...
Scanning for dabbrevs...done
passed 1/16 dabbrev-completion-test (0.000245 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Scanning for dabbrevs...done
Making completion list...
passed 2/16 dabbrev-completion-test-with-argument (0.016201 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `*Completions*'
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `foo'
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Test dabbrev-expand-after-killing-buffer backtrace:
signal(ert-test-failed (((should (string= msg "No further dynamic ex
ert-fail(((should (string= msg "No further dynamic expansion for ‘ab
(if (unwind-protect (setq value-179 (apply fn-177 args-178)) (setq f
(let (form-description-181) (if (unwind-protect (setq value-179 (app
(let ((value-179 'ert-form-evaluation-aborted-180)) (let (form-descr
(let* ((fn-177 #'string=) (args-178 (condition-case err (list msg "N
(let ((msg (car (cdr (let* ((fn-165 ...) (args-166 ...)) (let (...)
(progn (save-current-buffer (set-buffer (get-buffer-create "foo")) (
(unwind-protect (progn (save-current-buffer (set-buffer (get-buffer-
(let* ((abbreviated-home-dir nil) (process-environment (cons (format
(progn (let* ((abbreviated-home-dir nil) (process-environment (cons
(unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
#f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi
#f(compiled-function () #<bytecode 0x89f25f780a416fe>)()
handler-bind-1(#f(compiled-function () #<bytecode 0x89f25f780a416fe>
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name dabbrev-expand-after-killing-buffer :
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test dabbrev-expand-after-killing-buffer condition:
(ert-test-failed
((should (string= msg "No further dynamic expansion for ‘ab’ found"))
:form
(string= "No further dynamic expansion for `ab' found"
"No further dynamic expansion for ‘ab’ found")
:value nil :explanation
(array-elt 33
(different-atoms (96 "#x60" "?`") (8216 "#x2018" "?‘")))))
FAILED 3/16 dabbrev-expand-after-killing-buffer (0.005580 sec) at lisp/dabbrev-tests.el:278
passed 4/16 dabbrev-expand-test (0.000275 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 5/16 dabbrev-expand-test-minibuffer-1 (0.267578 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 6/16 dabbrev-expand-test-minibuffer-2 (0.308566 sec)
Scanning for dabbrevs...99%
Scanning for dabbrevs...done
Expansion found in `dabbrev-expand.el'
Scanning for dabbrevs...99%
Scanning for dabbrevs...done
Expansion found in `dabbrev-expand.el'
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
Scanning for dabbrevs...99%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 7/16 dabbrev-expand-test-minibuffer-3 (0.562288 sec)
I-search: I
I-search: In
I-search: Ind
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 8/16 dabbrev-expand-test-minibuffer-4 (0.278303 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 9/16 dabbrev-expand-test-other-buffer-1 (0.274776 sec)
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Expansion found in `INSTALL_BEGIN'
passed 10/16 dabbrev-expand-test-other-buffer-2 (0.300569 sec)
Scanning for dabbrevs...99%
Scanning for dabbrevs...done
Expansion found in `dabbrev-expand.el'
Scanning for dabbrevs...99%
Scanning for dabbrevs...done
Expansion found in `dabbrev-expand.el'
Scanning for dabbrevs...done
Expansion found in `dabbrev-tests.el'
Test dabbrev-expand-test-other-buffer-3 backtrace:
signal(ert-test-failed (((should (string= (buffer-string) "Indic and
ert-fail(((should (string= (buffer-string) "Indic and")) :form (stri
(if (unwind-protect (setq value-92 (apply fn-90 args-91)) (setq form
(let (form-description-94) (if (unwind-protect (setq value-92 (apply
(let ((value-92 'ert-form-evaluation-aborted-93)) (let (form-descrip
(let* ((fn-90 #'string=) (args-91 (condition-case err (list (buffer-
(progn (find-file (expand-file-name "INSTALL_BEGIN" (let* ((testfile
(unwind-protect (progn (find-file (expand-file-name "INSTALL_BEGIN"
(let* ((abbreviated-home-dir nil) (process-environment (cons (format
(progn (let* ((abbreviated-home-dir nil) (process-environment (cons
(unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
#f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi
#f(compiled-function () #<bytecode 0x89f25f780a416fe>)()
handler-bind-1(#f(compiled-function () #<bytecode 0x89f25f780a416fe>
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name dabbrev-expand-test-other-buffer-3 :d
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test dabbrev-expand-test-other-buffer-3 condition:
(ert-test-failed
((should (string= (buffer-string) "Indic and")) :form
(string= "Indic\")) (execute-kbd-macro" "Indic and") :value nil
:explanation
(arrays-of-different-length 27 9 "Indic\")) (execute-kbd-macro"
"Indic and" first-mismatch-at 5)))
FAILED 11/16 dabbrev-expand-test-other-buffer-3 (0.561430 sec) at lisp/dabbrev-tests.el:175
I-search: I
I-search: In
I-search: Ind
Scanning for dabbrevs...100%
Scanning for dabbrevs...done
Test dabbrev-expand-test-other-buffer-4 backtrace:
user-error("No%s dynamic expansion for `%s' found" "" "execute-kbd-m
dabbrev-expand(nil)
funcall-interactively(dabbrev-expand nil)
command-execute(dabbrev-expand)
execute-kbd-macro([73 110 100 134217775])
(let (disabled-command-function) (find-file (expand-file-name "INSTA
(progn (let (disabled-command-function) (find-file (expand-file-name
(unwind-protect (progn (let (disabled-command-function) (find-file (
(let* ((abbreviated-home-dir nil) (process-environment (cons (format
(progn (let* ((abbreviated-home-dir nil) (process-environment (cons
(unwind-protect (progn (let* ((abbreviated-home-dir nil) (process-en
(let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
#f(lambda () [t] (let* ((coding-system-for-write nil) (temp-file (fi
#f(compiled-function () #<bytecode 0x89f25f780a416fe>)()
handler-bind-1(#f(compiled-function () #<bytecode 0x89f25f780a416fe>
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name dabbrev-expand-test-other-buffer-4 :d
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
command-line()
normal-top-level()
Test dabbrev-expand-test-other-buffer-4 condition:
(user-error "No dynamic expansion for `execute-kbd-macroInd' found")
FAILED 12/16 dabbrev-expand-test-other-buffer-4 (0.291485 sec) at lisp/dabbrev-tests.el:194
passed 13/16 dabbrev-expand-test-same-buffer-1 (0.297619 sec)
passed 14/16 dabbrev-expand-test-same-buffer-2 (0.290400 sec)
passed 15/16 dabbrev-expand-test-same-buffer-3 (0.271752 sec)
I-search: I
I-search: In
I-search: Ind
passed 16/16 dabbrev-expand-test-same-buffer-4 (0.283636 sec)
Ran 16 tests, 13 results as expected, 3 unexpected (2024-12-03 09:13:32+0100, 5.467870 sec)
3 unexpected results:
FAILED dabbrev-expand-after-killing-buffer
FAILED dabbrev-expand-test-other-buffer-3
FAILED dabbrev-expand-test-other-buffer-4
prev parent reply other threads:[~2024-12-03 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <173314163483.652988.2881826266893472321@vcs3.savannah.gnu.org>
[not found] ` <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org>
2024-12-02 20:45 ` emacs-30 6bca138d60e: Fix latest test for dabbrev-expand Andrea Corallo
2024-12-02 22:16 ` Stephen Berman
2024-12-03 8:14 ` Andrea Corallo
2024-12-03 9:40 ` Stephen Berman
2024-12-03 9:55 ` Andrea Corallo
2024-12-03 8:19 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iks118m5.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).