From: Philip Kaludercic <philipk@posteo.net>
To: Spyros Roum <spyros.roum@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: Add completion to compilation-read-command
Date: Tue, 24 Dec 2024 12:53:03 +0000 [thread overview]
Message-ID: <87ikr9b5u8.fsf@posteo.net> (raw)
In-Reply-To: <c7618932-d64c-43db-a87f-5e063baf715b@posteo.net> (Spyros Roum's message of "Tue, 24 Dec 2024 11:57:15 +0000")
Spyros Roum <spyros.roum@posteo.net> writes:
> Philip Kaludercic wrote:
>> Spyros Roum<spyros.roum@posteo.net> writes:
>>
>>> Hello all,
>>>
>>> Recently, I started using `M-x compile` more but as I was used to my
>>> shell suggesting past commands as I type (and tools like atuin)
>> In case anyone else hasn't heard of this, it describes itself as
>>
>> Atuin replaces your existing shell history with a SQLite database, and
>> records additional context for your commands. Additionally, it
>> provides optional and fully encrypted synchronisation of your history
>> between machines, via an Atuin server.
>>
>> (https://github.com/atuinsh/atuin)
>
> Thanks for adding the description, I should have done that myself.
No worries.
>>> , I was
>>> missing auto-complete a lot.
>>> I managed to add this functionality by writing a simple function based
>>> on compilation-read-command that uses completing-read instead of
>>> read-shell-command.
>> Do you know about the `bash-completion' package? It enhances
>> `read-shell-command' completion with completion data provided by bash.
>> It is very easy to set up,
>>
>> (use-package bash-completion :ensure t
>> :init (bash-completion-setup))
>>
>> should do it.
>
> I was not aware of this, but it doesn't seem to do what I'm looking for.
> For once, I am not using bash, but even ignoring that it doesn't seem
> to have the effect I'm looking for.
>
> I'm trying to get the compile prompt to suggest completion based on
> past commands I've run.
My bad. In that case, why not use C-r to search `compile-history'?
>
>>> Then I used advice-add to overwrite the
>>> original compilation-read-command with mine.
>>>
>>> So far this works well, and as far as I can tell there is no good
>>> reason not to make compile auto-completing, it already has a history
>>> that you can navigate anyway.
>>>
>>> With that said, this is the first time I write here and the first time
>>> I'm trying to contribute to emacs, so I'm not sure what the best way
>>> to go from here would be.
>>> I think some decisions would need to be taken, for once I am not sure
>>> if it's acceptable to change the default and make it completing or if
>>> there should be an option for it.
>> I am not sure if you meant to attach any code, but that would probably
>> be the best place to start.
>>
>>> Looking forward to your feedback, thanks
>
> You are right I should have posted code, so here is what I have:
>
> (defun compilation-read-command-with-autocomplete (command)
> "Use `completing-read` to add autocomplete powers to compilation read"
> (completing-read "Compile command: " compile-history
> nil nil command
> (if (equal (car compile-history) command)
> '(compile-history . 1)
> 'compile-history)))
>
> (advice-add
> #'compilation-read-command
> :override #'compilation-read-command-with-autocomplete)
If this were added to Emacs, we probably wouldn't use advice. I think
the best strategy for you would be to prepare a patch against compile.el
and add a user option that allows prompting the user with
completing-read. What do you think?
next prev parent reply other threads:[~2024-12-24 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 8:53 Add completion to compilation-read-command Spyros Roum
2024-12-24 11:35 ` Philip Kaludercic
2024-12-24 11:57 ` Spyros Roum
2024-12-24 12:53 ` Philip Kaludercic [this message]
2024-12-24 13:43 ` Spyros Roum
2024-12-24 14:53 ` Philip Kaludercic
2024-12-24 17:03 ` Juri Linkov
2024-12-24 18:36 ` Spyros Roum
2024-12-24 18:50 ` Juri Linkov
2024-12-24 18:59 ` Spyros Roum
2024-12-24 22:35 ` Philip Kaludercic
2024-12-25 7:27 ` Juri Linkov
2024-12-24 19:56 ` [External] : " Drew Adams
2024-12-25 7:29 ` Juri Linkov
2024-12-24 22:44 ` Philip Kaludercic
2024-12-25 8:26 ` Spyros Roum
2024-12-25 11:33 ` Philip Kaludercic
2024-12-24 19:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikr9b5u8.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=spyros.roum@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).