unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Bruce Stephens <bruce@cenderis.demon.co.uk>
Cc: emacs-devel@gnu.org
Subject: diff-mode-hook (was Re: minor bug in next-error-follow-minor-mode?)
Date: Mon, 15 Aug 2005 19:17:14 +0100	[thread overview]
Message-ID: <87hddr5al1.fsf_-_@cenderis.demon.co.uk> (raw)
In-Reply-To: <200508151750.j7FHoMKE027188@scanner2.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 15 Aug 2005 10:50:19 -0700")

Dan Nicolaescu <dann@ics.uci.edu> writes:

> Bruce Stephens <bruce@cenderis.demon.co.uk> writes:

[...]

>   > and indeed found that C-c C-f switched it off (and another C-c C-f
>   > switched it on).  However, now I look at the code, I think it's just a
>   > minor bug, where ":init-value" ought to be ":lighter", in simple.el.
>   > (" Fol" is presumably a valid non-nil value, but it looks suspiciously
>   > like something meant for the modeline.)
>
> You are right, I fixed this.

Yes, I just noticed.  Thanks for that.

While investigating that, I tried switching on
next-error-follow-minor-mode explicitly:

(add-hook 'diff-mode-hook (function () (next-error-follow-minor-mode t)))

But that failed, and then I tried a function that did (setq foo 42),
and that didn't seem to set foo.  

I suspect diff-mode doesn't call diff-mode-hook.  The documentation
for diff-mode doesn't say it does, but diff-mode-hook does suggest it
gets called.  So something seems wrong.

  reply	other threads:[~2005-08-15 18:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-15 16:24 minor bug in next-error-follow-minor-mode? Bruce Stephens
2005-08-15 17:50 ` Dan Nicolaescu
2005-08-15 18:17   ` Bruce Stephens [this message]
2005-08-15 18:32     ` diff-mode-hook (was Re: minor bug in next-error-follow-minor-mode?) Dan Nicolaescu
2005-08-15 19:51       ` diff-mode-hook Bruce Stephens
2005-08-16  2:25     ` diff-mode-hook (was Re: minor bug in next-error-follow-minor-mode?) Richard M. Stallman
2005-08-16  2:25 ` minor bug in next-error-follow-minor-mode? Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hddr5al1.fsf_-_@cenderis.demon.co.uk \
    --to=bruce@cenderis.demon.co.uk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).