unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
Subject: Re: confusing info in C-u C-x =
Date: Sun, 11 Dec 2005 02:55:07 +0200	[thread overview]
Message-ID: <87hd9gqvbm.fsf@jurta.org> (raw)
In-Reply-To: <87u0divrk2.fsf@jurta.org> (Juri Linkov's message of "Fri, 09 Dec 2005 11:57:38 +0200")

BTW, there is an old bug related to read-only text in the *Help*
buffer produced by `describe-char'.

On any character type `C-u C-x = C-h C-h' and it signals an error

  Text is read-only: "Attempt to change text outside editable field"

while it tries to display the help-for-help screen.

I recall there was a discussion about changing `erase-buffer'
to ignore read-only text.  If it is not the time to change this now,
then I propose the following fix:

Index: lisp/help-macro.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/help-macro.el,v
retrieving revision 1.34
diff -c -r1.34 help-macro.el
*** lisp/help-macro.el	6 Aug 2005 22:13:43 -0000	1.34
--- lisp/help-macro.el	11 Dec 2005 00:54:56 -0000
***************
*** 139,146 ****
  				(setq new-frame (window-frame (selected-window))
  				      config nil))
  			   (setq buffer-read-only nil)
! 			   (erase-buffer)
! 			   (insert help-screen)
  			   (help-mode)
  			   (goto-char (point-min))
  			   (while (or (memq char (append help-event-list
--- 139,147 ----
  				(setq new-frame (window-frame (selected-window))
  				      config nil))
  			   (setq buffer-read-only nil)
! 			   (let ((inhibit-read-only t))
! 			     (erase-buffer)
! 			     (insert help-screen))
  			   (help-mode)
  			   (goto-char (point-min))
  			   (while (or (memq char (append help-event-list

-- 
Juri Linkov
http://www.jurta.org/emacs/

  parent reply	other threads:[~2005-12-11  0:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-20  9:55 confusing info in C-u C-x = Werner LEMBERG
2005-11-20 15:16 ` Andreas Schwab
2005-11-20 22:07   ` [SPAM?]: " Werner LEMBERG
2005-11-21  7:35   ` Juri Linkov
2005-12-08  1:49   ` Kenichi Handa
2005-12-09  9:57     ` Juri Linkov
2005-12-09 15:07       ` Kim F. Storm
2005-12-09 21:15       ` Richard M. Stallman
2005-12-09 23:52         ` Juri Linkov
2005-12-10 16:18           ` Richard M. Stallman
2005-12-11  0:46             ` Juri Linkov
2005-12-10 22:50           ` Kim F. Storm
2005-12-11  0:55       ` Juri Linkov [this message]
2005-12-11 16:49         ` Richard M. Stallman
2005-11-20 23:21 ` Richard M. Stallman
  -- strict thread matches above, loose matches on Subject: below --
2005-11-20 19:35 martin rudalics
2005-11-21  8:56 martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hd9gqvbm.fsf@jurta.org \
    --to=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).