Init X display on -nw.

Init X display on -nw.

[Michaël Cadilhac]

[-- Attachment #1.1.1: Type: text/plain, Size: 507 bytes --]


I've a distant computer that sets the DISPLAY value on ssh, but it has
a so old X server that Emacs can't connect to it. No problem, it's not
due to Emacs.

However, I then use `emacs -nw'.

Well, I don't see the point of this message :

  $ emacs -nw
  Xlib: connection to "localhost:10.0" refused by server
  Xlib: Invalid MIT-MAGIC-COOKIE-1 key
  Display localhost:10.0 unavailable, simulating -nw
  $

Emacs, my dear, please don't simulate, do it.

I propose the following (maybe naive) tiny change :


[-- Attachment #1.1.2: dispnew.patch --]
[-- Type: text/x-patch, Size: 1368 bytes --]

Index: src/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/src/ChangeLog,v
retrieving revision 1.4998
diff -b -c -w -r1.4998 ChangeLog
*** src/ChangeLog	11 Apr 2006 07:13:33 -0000	1.4998
--- src/ChangeLog	11 Apr 2006 19:35:22 -0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2006-04-11  Michaël Cadilhac  <michael.cadilhac@lrde.org> (tiny change)
+ 
+ 	* dispnew.c (init_display): Don't init X display if the user asked
+ 	for a non-X display.
+ 
  2006-04-11  Dan Nicolaescu  <dann@ics.uci.edu>
  
  	* lisp.h (wrong_type_argument): Mark as NO_RETURN.
Index: src/dispnew.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/dispnew.c,v
retrieving revision 1.361
diff -b -c -w -r1.361 dispnew.c
*** src/dispnew.c	20 Mar 2006 22:41:12 -0000	1.361
--- src/dispnew.c	11 Apr 2006 19:35:22 -0000
***************
*** 6654,6660 ****
       try to use X, and die with an error message if that doesn't work.  */
  
  #ifdef HAVE_X_WINDOWS
!   if (! display_arg)
      {
        char *display;
  #ifdef VMS
--- 6654,6660 ----
       try to use X, and die with an error message if that doesn't work.  */
  
  #ifdef HAVE_X_WINDOWS
!   if (!inhibit_window_system && !display_arg)
      {
        char *display;
  #ifdef VMS

[-- Attachment #1.1.3: Type: text/plain, Size: 347 bytes --]



Thanks in advance.

-- 
 |      Michaël `Micha' Cadilhac   |   Mieux vaut se taire                  |
 |         Epita/LRDE Promo 2007   |    Que de parler trop fort.            |
 | http://www.lrde.org/~cadilh_m   |            -- As de trèfle             |
 `--  -   JID: micha@amessage.be --'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Init X display on -nw.

[Jan D.]

Michaël Cadilhac wrote:
> I've a distant computer that sets the DISPLAY value on ssh, but it has
> a so old X server that Emacs can't connect to it. No problem, it's not
> due to Emacs.
> 
> However, I then use `emacs -nw'.
> 
> Well, I don't see the point of this message :
> 
>   $ emacs -nw
>   Xlib: connection to "localhost:10.0" refused by server
>   Xlib: Invalid MIT-MAGIC-COOKIE-1 key
>   Display localhost:10.0 unavailable, simulating -nw
>   $
> 
> Emacs, my dear, please don't simulate, do it.
> 
> I propose the following (maybe naive) tiny change :

Checked in.

	Jan D.