From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Fri, 24 Nov 2006 23:18:51 -0500 Message-ID: <87hcwokvkk.fsf@furball.mit.edu> References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1164428380 27090 80.91.229.2 (25 Nov 2006 04:19:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 25 Nov 2006 04:19:40 +0000 (UTC) Cc: Bob Rogers , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 05:19:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gnp0r-0000Aw-7Q for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 05:19:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gnp0q-0004nd-8t for ged-emacs-devel@m.gmane.org; Fri, 24 Nov 2006 23:19:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gnp0X-0004mr-U4 for emacs-devel@gnu.org; Fri, 24 Nov 2006 23:19:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gnp0X-0004lu-6U for emacs-devel@gnu.org; Fri, 24 Nov 2006 23:19:17 -0500 Original-Received: from [18.72.1.2] (helo=south-station-annex.mit.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1Gnp0X-000523-1g for emacs-devel@gnu.org; Fri, 24 Nov 2006 23:19:17 -0500 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id kAP4JFr2004349; Fri, 24 Nov 2006 23:19:15 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id kAP4IqDc022115; Fri, 24 Nov 2006 23:18:53 -0500 (EST) Original-Received: from furball.mit.edu (SYDNEYPACIFIC-THREE-EIGHTY-FIVE.MIT.EDU [18.95.6.130]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id kAP4IpR4017075; Fri, 24 Nov 2006 23:18:52 -0500 (EST) Original-Received: from cyd by furball.mit.edu with local (Exim 3.36 #1 (Debian)) id 1Gnp07-0000df-00; Fri, 24 Nov 2006 23:18:51 -0500 Original-To: YAMAMOTO Mitsuharu In-Reply-To: (YAMAMOTO Mitsuharu's message of "Sat\, 25 Nov 2006 10\:53\:42 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62765 Archived-At: YAMAMOTO Mitsuharu writes: >>>>>> On Mon, 20 Nov 2006 14:22:47 -0500, Chong Yidong said: > >> + #ifdef HAVE_WINDOW_SYSTEM >> + if (dpyinfo && EQ (window, dpyinfo->mouse_face_window)) >> + clear_mouse_face (dpyinfo); >> + #endif >> + >> unbind_to (count, Qnil); >> } > > This clear_mouse_face call is not protected by BLOCK_INPUT. Thanks, fixed. > Is it OK to refer to dpyinfo in window.c in the first place? Such > tasks seem to be done in xdisp.c usually. It is used in frame.c and several other files. I couldn't find any cleaner non-invasive solution.