From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: dbusbind.c SIGSEGV fix and minor cleanup Date: Fri, 21 Mar 2008 17:27:07 +0100 Message-ID: <87hcf0kppg.fsf@gmx.de> References: <87wso0nz34.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1206116819 19702 80.91.229.12 (21 Mar 2008 16:26:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Mar 2008 16:26:59 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 21 17:27:25 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jck5T-0001LE-Nd for ged-emacs-devel@m.gmane.org; Fri, 21 Mar 2008 17:27:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jck4t-0004sn-3G for ged-emacs-devel@m.gmane.org; Fri, 21 Mar 2008 12:26:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jck3x-0003wd-79 for emacs-devel@gnu.org; Fri, 21 Mar 2008 12:25:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jck3v-0003uE-5r for emacs-devel@gnu.org; Fri, 21 Mar 2008 12:25:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jck3v-0003u4-26 for emacs-devel@gnu.org; Fri, 21 Mar 2008 12:25:47 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Jck3u-0001rV-Mo for emacs-devel@gnu.org; Fri, 21 Mar 2008 12:25:47 -0400 Original-Received: (qmail invoked by alias); 21 Mar 2008 16:25:45 -0000 Original-Received: from p57A23DD1.dip0.t-ipconnect.de (EHLO arthur.local) [87.162.61.209] by mail.gmx.net (mp012) with SMTP; 21 Mar 2008 17:25:45 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1+oyEI7vDmodOyYfxMuYgJ0iRs62CJHw+hs4tvfpj DOArVbG74xh2VE In-Reply-To: <87wso0nz34.fsf@localhorst.mine.nu> (David Hansen's message of "Tue, 18 Mar 2008 10:47:11 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:93118 Archived-At: David Hansen writes: > Hello, Hi, > emacs crashes (in `strcpy') when receiving dbus messages with some empty > content. > > The attached patch fixes this. Also there is no need to copy the > strings. This is already be done by `build_string'. The patch looks OK to me. One could argue, that in case interface or member is NULL, this could be regarded as wildcards, and all registered functions which match otherwise shall be applied. But I agree with you, that only messages, which are sent to a specified interface and its member, shall be taken. One minor point: before "RETURN_UNGCPRO (Qnil)" you might call "dbus_message_unref (dmessage)" for freeing dmessage. Or you simply jump to the end, where it is done already. Please commit the patch, or (in case you have no write access in CVS) send the ChangeLog entry; I'll do it then. > David Thanks, and best regards, Michael.