sans-serif name change

sans-serif name change

[Miles Bader]

Why the following change?  At least according to debian's
font-infrastructure, "Sans-Serif" is the canonical name...

   2008-06-25  Andreas Schwab  <schwab@suse.de>

           * faces.el (face-font-family-alternatives, variable-pitch): Use
           "Sans Serif", not "Sans-Serif".

Thanks,

-Miles

-- 
Happiness, n. An agreeable sensation arising from contemplating the misery of
another.

Re: sans-serif name change

[Andreas Schwab]

Miles Bader <miles@gnu.org> writes:

> Why the following change?  At least according to debian's
> font-infrastructure, "Sans-Serif" is the canonical name...

Have you tried it?  Sans-Serif does not work.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sans-serif name change

[Miles Bader]

Andreas Schwab <schwab@suse.de> writes:
>> Why the following change?  At least according to debian's
>> font-infrastructure, "Sans-Serif" is the canonical name...
>
> Have you tried it?  Sans-Serif does not work.

I've just tried both, and see the following:

  (set-frame-font "Sans-Serif-10")

works fine, but:

  (set-face-attribute 'variable-pitch nil :family "Sans-Serif")

does not (it uses some random font instead); using "Sans Serif" does
work with set-face-attribute.

So it looks like there's a bug somewhere (but we should fix that, not
kludge around it).

-Miles

-- 
Yo mama's so fat when she gets on an elevator it HAS to go down.

Re: sans-serif name change

[Andreas Schwab]

Miles Bader <miles.bader@necel.com> writes:

> So it looks like there's a bug somewhere (but we should fix that, not
> kludge around it).

Ypu cannot use a dash in a font name in XFT.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sans-serif name change

[Jason Rumney]

Miles Bader wrote:

>   (set-face-attribute 'variable-pitch nil :family "Sans-Serif")
> 
> does not (it uses some random font instead); using "Sans Serif" does
> work with set-face-attribute.
> 
> So it looks like there's a bug somewhere (but we should fix that, not
> kludge around it).

My guess is that the `-' in Sans-Serif is being treated as a separator
character, and causes Emacs to look for a font called Serif with the
foundry Sans, or something similar.

Re: sans-serif name change

[James Cloos]

>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:

Andreas> You cannot use a dash in a font name in XFT.

Since I posted the note that Sans-Serif is the canonical name for the
fontconfig alias:

I forgot that point.  Fontconfig backslash-escapes dashes in font names
in the output of command such as fc-cat, fc-list, fc-match.  Using a
space, though, probably triggers the GTK fontname path.

So emacs should probably ignore that the canonical name is Sans-Serif
and go back to using Sans, in the hope that that alias will remain in
the shipped fontconfig configs.

Sorry for the time waste!

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

Re: sans-serif name change

[Kenichi Handa]

In article <4862198F.4060305@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:

> My guess is that the `-' in Sans-Serif is being treated as a separator
> character, and causes Emacs to look for a font called Serif with the
> foundry Sans, or something similar.

Yes.  I didn't change that behaviour for backward
compatibility, but as face has the attribute :foundy now, it
may be ok to break that compatibility.

The parsing of XXX-YYY as FOUNDRY-FAMILY is now done in
the function set-face-attribute as this:

	(if (and (eq (car args) :family)
		 (stringp (cadr args))
		 (string-match "\\([^-]*\\)-\\([^-]*\\)" (cadr args)))
	    (let ((foundry (match-string 1 (cadr args)))
		  (family (match-string 2 (cadr args))))
	      (internal-set-lisp-face-attribute face :foundry
						(purecopy foundry)
						where)
	      (internal-set-lisp-face-attribute face :family
						(purecopy family)
						where))
	  (internal-set-lisp-face-attribute face (car args)
					    (purecopy (cadr args))
					    where)))

---
Kenichi Handa
handa@ni.aist.go.jp

Re: sans-serif name change

[Miles Bader]

Andreas Schwab <schwab@suse.de> writes:
>> So it looks like there's a bug somewhere (but we should fix that, not
>> kludge around it).
>
> Ypu cannot use a dash in a font name in XFT.

Eh?  Clearly you can, as (1) `set-frame-font' works properly with
"Sans-Serif", and (2) `set-frame-attribute' works properly as well, once
the hack in the lisp code (of set-frame-attribute, which Kenichi
described) is removed.

-Miles

-- 
Monday, n. In Christian countries, the day after the baseball game.

Re: sans-serif name change

[Andreas Schwab]

Miles Bader <miles@gnu.org> writes:

> Andreas Schwab <schwab@suse.de> writes:
>>> So it looks like there's a bug somewhere (but we should fix that, not
>>> kludge around it).
>>
>> Ypu cannot use a dash in a font name in XFT.
>
> Eh?  Clearly you can,

Try xfd -fa "Sans-Serif-8" and compare that with xfd -fa "Sans Serif-8".

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sans-serif name change

[Miles Bader]

Andreas Schwab <schwab@suse.de> writes:
>>>> So it looks like there's a bug somewhere (but we should fix that, not
>>>> kludge around it).
>>>
>>> Ypu cannot use a dash in a font name in XFT.
>>
>> Eh?  Clearly you can,
>
> Try xfd -fa "Sans-Serif-8" and compare that with xfd -fa "Sans Serif-8".

Those commands give different results.

However, in Emacs, they give the same result; try:

   (set-frame-font "Sans Serif-8")

and:

   (set-frame-font "Sans-Serif-8")
   
Result:  same.

So the font-parser in xfd seems to be broken, whereas one in Emacs is
not.

Since we are discussing Emacs, there would seem to be no problem.

-Miles

-- 
Patience, n. A minor form of despair, disguised as a virtue.

Re: sans-serif name change

[Andreas Schwab]

Miles Bader <miles@gnu.org> writes:

> Since we are discussing Emacs, there would seem to be no problem.

Since "Sans Serif" works everywhere (and all other frontends seem to be
using dash-less names) it should be preferred, IMHO.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: sans-serif name change

[Stefan Monnier]

>> My guess is that the `-' in Sans-Serif is being treated as a separator
>> character, and causes Emacs to look for a font called Serif with the
>> foundry Sans, or something similar.

> Yes.  I didn't change that behaviour for backward
> compatibility, but as face has the attribute :foundy now, it
> may be ok to break that compatibility.

> The parsing of XXX-YYY as FOUNDRY-FAMILY is now done in
> the function set-face-attribute as this:

> 	(if (and (eq (car args) :family)
> 		 (stringp (cadr args))
> 		 (string-match "\\([^-]*\\)-\\([^-]*\\)" (cadr args)))
> 	    (let ((foundry (match-string 1 (cadr args)))
> 		  (family (match-string 2 (cadr args))))
> 	      (internal-set-lisp-face-attribute face :foundry
> 						(purecopy foundry)
> 						where)
> 	      (internal-set-lisp-face-attribute face :family
> 						(purecopy family)
> 						where))
> 	  (internal-set-lisp-face-attribute face (car args)
> 					    (purecopy (cadr args))
> 					    where)))

Maybe this "FOUNDRY-FAMILY" fallback code could be moved to the same
code that handles face-font-family-alternatives?


        Stefan

Re: sans-serif name change

[Kenichi Handa]

In article <jwviqvxk4bq.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

> > The parsing of XXX-YYY as FOUNDRY-FAMILY is now done in
> > the function set-face-attribute as this:
[...]
> Maybe this "FOUNDRY-FAMILY" fallback code could be moved to the same
> code that handles face-font-family-alternatives?

It can find a font of FOUNDRY and FAMILY, but face
attributes are not updated propery with that change, i.e.
(set-face-attribute 'variable-pitch nil :family "misc-fixed")
(face-attribute 'variable-pitch :family) => "misc-fixed"
(face-attribute 'variable-pitch :foundry) => unspecified

Currently, we have:
(set-face-attribute 'variable-pitch nil :family "misc-fixed")
(face-attribute 'variable-pitch :family) => "fixed"
(face-attribute 'variable-pitch :foundry) => "misc"

And, fontconfig requires `-' in a family name to be escaped
by `\':

% fc-list 'DV-TTSurekh'
% fc-list 'DV\-TTSurekh'
DV\-TTSurekh:style=Normal

So, how about using the same rule for Emacs?

(set-face-attribute 'variable-pitch nil :family "sans\\-serif")

---
Kenichi Handa
handa@ni.aist.go.jp

Re: sans-serif name change

[Miles Bader]

Kenichi Handa <handa@m17n.org> writes:
> And, fontconfig requires `-' in a family name to be escaped
> by `\':
..
> So, how about using the same rule for Emacs?
>
> (set-face-attribute 'variable-pitch nil :family "sans\\-serif")

But currently other places, such as `set-frame-font' seem to work
properly if passed "Sans-Serif" without escaping the "-".  Perhaps some
part of emacs is already adding the backslash?

I think _if_ there are fonts with "-" in their name, requiring the dash
to be escaped will annoy and confuse users, and lead to bug reports.
I don't know how many such fonts there are, of course.

[I'd say just get rid of the old-style foundry-family names; do we
really care?]

-Miles

-- 
My books focus on timeless truths.  -- Donald Knuth

Re: sans-serif name change

[Kenichi Handa]

In article <buo7icb1fnp.fsf@dhapc248.dev.necel.com>, Miles Bader <miles.bader@necel.com> writes:

> Kenichi Handa <handa@m17n.org> writes:
> > And, fontconfig requires `-' in a family name to be escaped
> > by `\':
..
> > So, how about using the same rule for Emacs?
> >
> > (set-face-attribute 'variable-pitch nil :family "sans\\-serif")

> But currently other places, such as `set-frame-font' seem to work
> properly if passed "Sans-Serif" without escaping the "-".  Perhaps some
> part of emacs is already adding the backslash?

No.  In ftfont.c, these names:

  "mono", "monospace", "sans-serif", "sans serif", "sans", "serif"

are specially recognized as generic family names.  In
addition, fontconfig accepts the literal "sans-serif" when
used in the function FcPatternAddString (pat, FC_FAMILY, ...).
Fontconfig requires escaping only on parsing a font name,
and adds escaping on generating a font name.

> I think _if_ there are fonts with "-" in their name, requiring the dash
> to be escaped will annoy and confuse users, and lead to bug reports.
> I don't know how many such fonts there are, of course.

> [I'd say just get rid of the old-style foundry-family names; do we
> really care?]

As I wrote before, I tend to agree with breaking the
backward compatibility here.

---
Kenichi Handa
handa@ni.aist.go.jp