From: Chong Yidong <cyd@stupidchicken.com>
To: Michael Olson <mwolson@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: The latest lisp/faces.el changes seem to break color-themes again
Date: Thu, 16 Oct 2008 12:07:15 -0400 [thread overview]
Message-ID: <87hc7ccymk.fsf@cyd.mit.edu> (raw)
In-Reply-To: <87abd4vfyb.fsf@grepfind.mwolson.org> (Michael Olson's message of "Thu, 16 Oct 2008 06:15:40 -0700")
Michael Olson <mwolson@gnu.org> writes:
> Miles Bader <miles@gnu.org> writes:
>
>> Manoj Srivastava <srivasta@ieee.org> writes:
>>>> Are color themes supposed to be supported?
>>>
>>> While I am hoping they are, the actual code that is made invalid
>>> is immaterial: color-themes are on example of long-standing user
>>> customization that is breaking. While user customizations are not
>>> always going to be supportable, I think one ought to minimize such
>>> breakage, since it is likely to be seen as regressions.
>>
>> It's just that I have a vague memory of color-themes doing some decidely
>> dodgy stuff. (I haven't looked at in ages though)
>
> The problem could possibly be due to Emacs having problems with using
> ":foreground nil" in a defface statement. I just received a patch for
> EMMS to that effect.
Could you come up with a test case that shows how Emacs fails now,
compared to before?
next prev parent reply other threads:[~2008-10-16 16:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 5:19 The latest lisp/faces.el changes seem to break color-themes again Manoj Srivastava
2008-10-16 6:08 ` Miles Bader
2008-10-16 7:01 ` Manoj Srivastava
2008-10-16 7:09 ` Miles Bader
2008-10-16 13:15 ` Michael Olson
2008-10-16 16:07 ` Chong Yidong [this message]
2008-10-16 16:36 ` Chong Yidong
2008-10-16 18:09 ` Chming
2008-10-16 19:08 ` Chong Yidong
2008-10-16 20:15 ` Chming
2008-10-16 20:49 ` Chong Yidong
2008-10-16 22:55 ` Lennart Borgman (gmail)
2008-10-16 23:09 ` Lennart Borgman (gmail)
2008-10-17 3:09 ` Chong Yidong
2008-10-17 7:49 ` Lennart Borgman (gmail)
2008-10-17 17:16 ` Chong Yidong
2008-10-17 17:54 ` Chming
2008-10-17 4:17 ` Manoj Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hc7ccymk.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=mwolson@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).