From: Juri Linkov <juri@jurta.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: support for git commit --amend/--signoff
Date: Fri, 11 Jun 2010 11:09:36 +0300 [thread overview]
Message-ID: <87hblavx6f.fsf@mail.jurta.org> (raw)
In-Reply-To: <yxqwru6147x.fsf@fencepost.gnu.org> (Dan Nicolaescu's message of "Fri, 11 Jun 2010 02:19:14 -0400")
> It would be nice if VC commit would support --amend and --signoff for git.
>
> The patch below adds key bindings to toggle some variables in the log-edit buffer.
> (for --amend it also inserts the contents of the last commit message)
>
> Now vc-git-checkin needs to know any of these variables has been set,
> so that it can pass the right flags to the git commit command.
>
> Other VC backends might want to implement similar things.
>
> What is the best way to pass custom flags to the vc-checkin command?
The same way as you pass Author:, Summary: and Fixes:?
BTW, Author:, Summary: and Fixes: need key bindings too.
What about using the same key prefix as message-mode - `C-c C-f'?
I.e. like `C-c C-f C-s' (`message-goto-subject')
to add `C-c C-f C-s' (`log-edit-goto-subject'), etc.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-06-11 8:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 6:19 support for git commit --amend/--signoff Dan Nicolaescu
2010-06-11 8:09 ` Juri Linkov [this message]
2010-06-11 13:23 ` Dan Nicolaescu
2010-06-11 14:18 ` Stefan Monnier
2010-06-11 16:14 ` Štěpán Němec
2010-06-11 20:26 ` Stefan Monnier
2010-06-12 2:19 ` Dan Nicolaescu
2010-06-12 19:59 ` Juri Linkov
2010-06-12 20:19 ` Stefan Monnier
2010-06-19 6:38 ` Dan Nicolaescu
2010-06-23 7:17 ` Stefan Monnier
2010-06-23 7:45 ` David Kastrup
2010-06-23 9:00 ` Miles Bader
2010-06-23 18:55 ` Dan Nicolaescu
2010-06-23 18:45 ` Dan Nicolaescu
2010-06-23 22:04 ` Stefan Monnier
2010-06-23 23:23 ` Dan Nicolaescu
2010-06-24 21:03 ` Stefan Monnier
2010-06-24 21:18 ` Dan Nicolaescu
2010-06-24 22:25 ` Stefan Monnier
2010-06-24 23:14 ` Dan Nicolaescu
2010-06-25 1:16 ` Stefan Monnier
2010-06-25 2:27 ` Dan Nicolaescu
2010-06-25 11:44 ` Miles Bader
2010-06-26 5:09 ` Dan Nicolaescu
2010-07-01 0:01 ` Stefan Monnier
2010-06-26 10:11 ` David Kastrup
2010-06-28 21:04 ` Juri Linkov
2010-06-11 17:34 ` Dan Nicolaescu
2010-06-11 19:27 ` Juri Linkov
2010-06-11 20:16 ` Dan Nicolaescu
2010-06-11 20:38 ` Juri Linkov
2010-06-11 23:48 ` W Dan Meyer
2010-06-12 20:23 ` Juri Linkov
2010-06-12 2:21 ` Dan Nicolaescu
2010-06-11 23:44 ` Thien-Thi Nguyen
2010-06-12 20:15 ` Stefan Monnier
2010-06-11 20:35 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hblavx6f.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).