Confused about emacs-23 revno: 100005

Confused about emacs-23 revno: 100005

[Glenn Morris]

I'm confused about emacs-23 revno: 100005

    committer: Michael Albinus <michael.albinus at gmx.de>
    branch nick: emacs-23
    timestamp: Thu 2010-08-26 21:23:02 +0200


Firstly, it does not show up at all in the emacs-diffs mailing list.
Maybe the diff is too big, but I thought at least the list was
supposed to send out a message saying "diff too big", rather than do
nothing? Eg compare

http://lists.gnu.org/archive/html/emacs-diffs/2010-07/msg00193.html


Secondly, did this change go to the right branch? A 7000 line diff
seems large for the emacs-23 branch. Eg lisp/ChangeLog contains
several entries related to selinux; but the selinux primitives
(file-selinux-context etc) are only in the trunk, so I don't see why
this change ended up in emacs-23.

Re: Confused about emacs-23 revno: 100005

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Sat, 28 Aug 2010 15:49:51 -0400
> Cc: michael.albinus@gmx.de
> 
> Secondly, did this change go to the right branch? A 7000 line diff
> seems large for the emacs-23 branch. Eg lisp/ChangeLog contains
> several entries related to selinux; but the selinux primitives
> (file-selinux-context etc) are only in the trunk, so I don't see why
> this change ended up in emacs-23.

Maybe Michael meant to commit to the trunk, or committed from a wrong
branch?

Re: Confused about emacs-23 revno: 100005

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Glenn Morris <rgm@gnu.org>
>> Date: Sat, 28 Aug 2010 15:49:51 -0400
>> Cc: michael.albinus@gmx.de
>> 
>> Secondly, did this change go to the right branch? A 7000 line diff
>> seems large for the emacs-23 branch. Eg lisp/ChangeLog contains
>> several entries related to selinux; but the selinux primitives
>> (file-selinux-context etc) are only in the trunk, so I don't see why
>> this change ended up in emacs-23.
>
> Maybe Michael meant to commit to the trunk, or committed from a wrong
> branch?

No, I meant committing to the Emacs 23 branch.

This is a sync with Tramp 2.1.19 (as indicated in the Changelog). Don't
know, why there is no email in  emacs-diff.

It is huge, I know (changes of the last 5 months in Tramp). But I do
plan to start with Tramp 2.2, which includes a rearrangement of the
files, in order to solve the heavy load dependencies. This will go into
the trunk. That's why, Tramp 2.1 will be kept in the Emacs 23 branch
only, and I have done the sync.

Carrying new features of the trunk (like selinux) is not necessary for
the branch, of course. But separating new features from just bug fixes
would be error prone. And Tramp 2.1 will live also outside the
repository, also for Emacs 22 and XEmacs. Compatibility shall be
ensured.

Sorry for the inconvenience.

Best regards, Michael.

Re: Confused about emacs-23 revno: 100005

[Glenn Morris]

Michael Albinus wrote:

> No, I meant committing to the Emacs 23 branch.

OK.

> This is a sync with Tramp 2.1.19 (as indicated in the Changelog). Don't
> know, why there is no email in  emacs-diff.

Maybe the mail reached emacs-diff but was above the list size threshold?
emacs-diff admin, can you shed any light? :)

Otherwise I can ask Savannah, but since it's related to bzr...

Re: Confused about emacs-23 revno: 100005

[Eli Zaretskii]

> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> From: Glenn Morris <rgm@gnu.org>
> Date: Sat, 28 Aug 2010 21:46:56 -0400
> 
> Maybe the mail reached emacs-diff but was above the list size threshold?
> emacs-diff admin, can you shed any light? :)

Unless it is discarded automatically (I don't think it does), it never
reached emacs-diffs, because I would certainly have let it be sent to
the list.