From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: DBus methods without name grabbing Date: Mon, 10 Jan 2011 12:40:58 +0100 Message-ID: <87hbdhugtx.fsf@gmx.de> References: <19384_1294002375_ZZh0g13mCbLkV.00_1294002364.12635.44.camel@gunhead> <87lj32kuyz.fsf@gmx.de> <7758_1294108975_ZZh0g0_f99~qx.00_1294108972.8785.33.camel@gunhead> <87zkrhf081.fsf@gmx.de> <26843_1294201050_ZZh0g3doKzQB1.00_1294201048.2508.1.camel@gunhead> <87hbdnvakj.fsf@gmx.de> <3138_1294465704_ZZh0g6t4U5Dm1.00_1294465702.2322.47.camel@gunhead> <8739p2pg5i.fsf@gmx.de> <24098_1294589394_ZZh0g1BtrpOWT.00_1294589334.2322.207.camel@gunhead> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1294659683 21965 80.91.229.12 (10 Jan 2011 11:41:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 10 Jan 2011 11:41:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Jan Moringen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 10 12:41:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PcG7g-0000S2-LO for ged-emacs-devel@m.gmane.org; Mon, 10 Jan 2011 12:41:16 +0100 Original-Received: from localhost ([127.0.0.1]:57168 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcG7g-0008IQ-3B for ged-emacs-devel@m.gmane.org; Mon, 10 Jan 2011 06:41:16 -0500 Original-Received: from [140.186.70.92] (port=53672 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcG7b-0008IG-5x for emacs-devel@gnu.org; Mon, 10 Jan 2011 06:41:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcG7Z-0002AD-W1 for emacs-devel@gnu.org; Mon, 10 Jan 2011 06:41:11 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:48602 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PcG7Z-00029p-KA for emacs-devel@gnu.org; Mon, 10 Jan 2011 06:41:09 -0500 Original-Received: (qmail invoked by alias); 10 Jan 2011 11:41:07 -0000 Original-Received: from p57BBD461.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.212.97] by mail.gmx.net (mp072) with SMTP; 10 Jan 2011 12:41:07 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19kQzY7jgZkl5CN4P9BhFiwvG20DkYsD++mpmDsWf LOUF+3H8bXi7ik In-Reply-To: <24098_1294589394_ZZh0g1BtrpOWT.00_1294589334.2322.207.camel@gunhead> (Jan Moringen's message of "Sun, 09 Jan 2011 17:08:54 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:134405 Archived-At: Jan Moringen writes: > Hi Michael, Hi Jan, > sorry for the sloppy patch. I couldn't put as much time into it as I > would have liked. Don't worry. By this, I had something to comment :-) >> > + (dbus-register-method >> > + bus service path dbus-interface-properties "Set" >> > + 'dbus-property-handler nil) >> > + >> > + ;; Register the name SERVICE with BUS. >> > + (unless dont-register-service >> > + (dbus-register-service bus service)) >> >> I guess you mean t (or better 'dont-register) as last argument of the >> dbus-register-method calls. > > I think it has to be t. The service is registered or not in the > following call to `dbus-register-service' depending on > `dont-register-service'. I did not mean the value of `dont-register-service', but a symbol `dont-register'. For better readability, one could use a symbol describing what is meant with a non-nil value. > I hope this increases the quality of the patch to bearable levels. I have committed your patchset. Afterwards, I have applied some further minor tweakings. > Kind regards, > Jan Best regards, Michael.