From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Fri, 24 Jun 2011 05:19:20 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87hb7fh6qf.fsf@lifelogs.com> References: <201106040034.15598.ruediger@c-plusplus.de> <201106061825.25078.ruediger@c-plusplus.de> <201106240250.01247.ruediger@c-plusplus.de> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1308916179 8245 80.91.229.12 (24 Jun 2011 11:49:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2011 11:49:39 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 24 13:49:36 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qa4tC-0001ku-Su for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2011 13:49:35 +0200 Original-Received: from localhost ([::1]:52794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa4tB-00044p-Tk for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2011 07:49:34 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:58991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa3U7-0004Xi-QP for emacs-devel@gnu.org; Fri, 24 Jun 2011 06:19:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa3U6-0001YC-BR for emacs-devel@gnu.org; Fri, 24 Jun 2011 06:19:35 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:33934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa3U5-0001Y5-SV for emacs-devel@gnu.org; Fri, 24 Jun 2011 06:19:34 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qa3U5-0002mq-7O for emacs-devel@gnu.org; Fri, 24 Jun 2011 12:19:33 +0200 Original-Received: from c-67-186-102-106.hsd1.il.comcast.net ([67.186.102.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2011 12:19:33 +0200 Original-Received: from tzz by c-67-186-102-106.hsd1.il.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2011 12:19:33 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 27 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: c-67-186-102-106.hsd1.il.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:YFopaFIhVImt8JaCotD8LWetgp8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140940 Archived-At: On Fri, 24 Jun 2011 02:50:00 +0200 Rüdiger Sonderfeld wrote: RS> +static Lisp_Object Qmodify, Qmove, Qattrib, Qdelete, Qfrom, Qto, Qall_modify; ... RS> + if (ev->mask & (IN_MODIFY|IN_CREATE) ) RS> + events = Fcons (Fcons (Qmodify, name), events); ... RS> + if (EQ (symb, Qmodify)) RS> + return IN_MODIFY | IN_CREATE; You have several symbols like Qmodify, and I wanted to suggest that you could use a name prefix like for example gnutls.c: #+begin_src c Qgnutls_bootprop_verify_hostname_error = intern_c_string (":verify-error"); staticpro (&Qgnutls_bootprop_verify_error); #+end_src and that you assign a numeric value directly to the symbol when it's initialized instead of statically doing case statements in your code. That way your code will be shorter and simpler because you'll work with the integer values directly. This could be a problem if the IN_* constants overflow the Emacs integer size, but I don't think they will, after checking inotify.h. Only the special flags are large (2147483648 = IN_ONESHOT = 0x80000000) and you won't use those. Ted