Trunk fails to compile on RHEL 5 machines

Trunk fails to compile on RHEL 5 machines

[Manoj Srivastava]

Hi,

        Ever since commit:

--8<---------------cut here---------------start------------->8---
Author: Chong Yidong <cyd@gnu.org>  2012-06-11 07:42:55
Committer: Chong Yidong <cyd@gnu.org>  2012-06-11 07:42:55
Parent: 4c8c631d6c08e10d72e845417ee3383a83629ce7 (New Tramp features.)
Child:  d0fa5b46571dcfc69a4cd89226f23db903ade97e (Don't purify in Fmake_byte_code.)
Branches: debian, master, remotes/origin/master
Follows: emacs-24.1
Precedes: 

    Support transparency for ImageMagick images.
    
    * src/image.c (imagemagick_load_image): Implement transparency.
    
    * doc/lispref/display.texi (ImageMagick Images): ImageMagick now supports the
    :background property.
--8<---------------cut here---------------end--------------->8---

        I am getting the following failure on a RHEL5 GNU?Linux machine:
--8<---------------cut here---------------start------------->8---
gcc -std=gnu99 -c  -Demacs -DHAVE_CONFIG_H  -I. -I/usr/local/src/emacs/src -I../lib -I/usr/local/src/emacs/src/../lib   -I/usr/include/freetype2    -I/usr/include/alsa   -I/usr/include/librsvg-2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0    -I/usr/include/libxml2   -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include   -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/freetype2    -I/usr/include/freetype2    -MMD -MF deps/image.d -MP  -I/usr/local/include     -g -O2 image.c
image.c: In function ‘imagemagick_load_image’:
image.c:7786: warning: implicit declaration of function ‘MagickMergeImageLayers’
image.c:7786: error: ‘MergeLayer’ undeclared (first use in this function)
image.c:7786: error: (Each undeclared identifier is reported only once
image.c:7786: error: for each function it appears in.)
image.c:7786: warning: assignment makes pointer from integer without a cast
image.c:7838: warning: passing argument 2 of ‘PixelGetNextIteratorRow’ from incompatible pointer type
image.c: In function ‘Fimagemagick_types’:
image.c:7999: warning: passing argument 2 of ‘GetMagickList’ from incompatible pointer type
make[1]: *** [image.o] Error 1
make[1]: Leaving directory `/usr/local/src/emacs/src'
make: *** [src] Error 2
--8<---------------cut here---------------end--------------->8---

        Previous to that commit Emacs compiled fine.

        manoj

-- 
He who walks on burning coals is sure to get burned. Sinbad
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
4096R/C5779A1C E37E 5EC5 2A01 DA25 AD20  05B6 CF48 9438 C577 9A1C

Re: Trunk fails to compile on RHEL 5 machines

[joakim]

Manoj Srivastava <srivasta@ieee.org> writes:

> Hi,
>
>         Ever since commit:
>
> Author: Chong Yidong <cyd@gnu.org>  2012-06-11 07:42:55
> Committer: Chong Yidong <cyd@gnu.org>  2012-06-11 07:42:55
> Parent: 4c8c631d6c08e10d72e845417ee3383a83629ce7 (New Tramp features.)
> Child:  d0fa5b46571dcfc69a4cd89226f23db903ade97e (Don't purify in Fmake_byte_code.)
> Branches: debian, master, remotes/origin/master
> Follows: emacs-24.1
> Precedes: 
>
>     Support transparency for ImageMagick images.
>     
>     * src/image.c (imagemagick_load_image): Implement transparency.
>     
>     * doc/lispref/display.texi (ImageMagick Images): ImageMagick now supports the
>     :background property.
>
>         I am getting the following failure on a RHEL5 GNU?Linux machine:
> gcc -std=gnu99 -c  -Demacs -DHAVE_CONFIG_H  -I. -I/usr/local/src/emacs/src -I../lib -I/usr/local/src/emacs/src/../lib   -I/usr/include/freetype2    -I/usr/include/alsa   -I/usr/include/librsvg-2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0    -I/usr/include/libxml2   -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include   -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -I/usr/include/freetype2    -I/usr/include/freetype2    -MMD -MF deps/image.d -MP  -I/usr/local/include     -g -O2 image.c
> image.c: In function ‘imagemagick_load_image’:
> image.c:7786: warning: implicit declaration of function ‘MagickMergeImageLayers’
> image.c:7786: error: ‘MergeLayer’ undeclared (first use in this function)

I would suspect that the above functions are not declared in the version
of ImageMagick shipping with RHEL5. I don't have a RHEL5 handy for
testing at the moment.

> image.c:7786: error: (Each undeclared identifier is reported only once
> image.c:7786: error: for each function it appears in.)
> image.c:7786: warning: assignment makes pointer from integer without a cast
> image.c:7838: warning: passing argument 2 of ‘PixelGetNextIteratorRow’ from incompatible pointer type
> image.c: In function ‘Fimagemagick_types’:
> image.c:7999: warning: passing argument 2 of ‘GetMagickList’ from incompatible pointer type
> make[1]: *** [image.o] Error 1
> make[1]: Leaving directory `/usr/local/src/emacs/src'
> make: *** [src] Error 2
>
>         Previous to that commit Emacs compiled fine.
>
>         manoj

-- 
Joakim Verona

Re: Trunk fails to compile on RHEL 5 machines

[Chong Yidong]

joakim@verona.se writes:

>> image.c: In function ‘imagemagick_load_image’:
>> image.c:7786: warning: implicit declaration of function ‘MagickMergeImageLayers’
>> image.c:7786: error: ‘MergeLayer’ undeclared (first use in this function)
>
> I would suspect that the above functions are not declared in the version
> of ImageMagick shipping with RHEL5. I don't have a RHEL5 handy for
> testing at the moment.

Indeed, this was the problem.  Older ImageMagick versions should use
MagickFlattenImages.  Fixed in trunk.

Re: Trunk fails to compile on RHEL 5 machines

[Manoj Srivastava]

On Tue, Jun 12 2012, Chong Yidong wrote:

> joakim@verona.se writes:
>
>>> image.c: In function ‘imagemagick_load_image’: image.c:7786:
>>> warning: implicit declaration of function ‘MagickMergeImageLayers’
>>> image.c:7786: error: ‘MergeLayer’ undeclared (first use in this
>>> function)
>>
>> I would suspect that the above functions are not declared in the
>> version of ImageMagick shipping with RHEL5. I don't have a RHEL5
>> handy for testing at the moment.
>
> Indeed, this was the problem.  Older ImageMagick versions should use
> MagickFlattenImages.  Fixed in trunk.

        I can confirm that Emacs trunk builds again on a RHEL5 machine.

        manoj
-- 
Many pages make a thick book.
Manoj Srivastava <srivasta@acm.org> <http://www.golden-gryphon.com/>  
4096R/C5779A1C E37E 5EC5 2A01 DA25 AD20  05B6 CF48 9438 C577 9A1C