unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Fabrice Niessen"
	<public-fni-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@plane.gmane.org>
Cc: public-emacs-devel-mXXj517/zsQ@plane.gmane.org
Subject: Re: Submitting a custom theme for GNU Emacs 24
Date: Wed, 21 Nov 2012 18:17:19 +0400	[thread overview]
Message-ID: <87haojxcpc.fsf@yandex.ru> (raw)
In-Reply-To: <80vcd7nff3.fsf@somewhere.org> (Fabrice Niessen's message of "Thu, 15 Nov 2012 14:50:40 +0100")

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

"Fabrice Niessen"
<fni-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@public.gmane.org> writes:

> Hello,
>
> Please find attached a custom theme (with a light background -- one of the
> few) that I'd like to see included in Emacs 24.

Here's some feedback on the theme, if you don't mind:
1) For the most part, the colors look good, the mode-line looks rather
modern, at last.
2) The red color of the comments looks grating, hard on the eyes.
3) The gnus message window looks very uneven.
4) The helm buffer looks rather bizarre.

For 3 and 4, see attached screenshots.

[-- Attachment #2: leuven-gnus.png --]
[-- Type: image/png, Size: 20436 bytes --]

[-- Attachment #3: leuven-helm.png --]
[-- Type: image/png, Size: 22617 bytes --]

  parent reply	other threads:[~2012-11-21 14:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 13:50 Submitting a custom theme for GNU Emacs 24 Fabrice Niessen
2012-11-20 13:22 ` Fabrice Niessen
2012-11-21 12:56   ` Chong Yidong
2012-11-21 14:17 ` Dmitry Gutov [this message]
2012-11-29 21:38   ` Fabrice Niessen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87haojxcpc.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=public-emacs-devel-mXXj517/zsQ@plane.gmane.org \
    --cc=public-fni-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).