unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Aidan Gauland <aidalgol@no8wireless.co.nz>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-diffs@gnu.org, emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module
Date: Fri, 29 Mar 2013 09:03:11 +1300	[thread overview]
Message-ID: <87hajvnvgg.fsf@dimension8.tehua.net> (raw)
In-Reply-To: <jwv8v57aco0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 28 Mar 2013 09:16:52 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> This said, IIUC just loading eshell-tramp.el will also enable it (tho
>>> not "completely").  That's a problem (and yes, this is not a new
>>> problem, it's just a problem in most/all eshell modules).
>> Yes, if the feature `em-tramp' is loaded but the module is not enabled,
>> then it is just taking up memory and doing nothing.
>
> Just taking up memory is not a problem.  But IIUC since it defines
> eshell/su, it will have an impact on eshell buffers, even if
> eshell-tramp-initialize is not called, right?

Oh, no, that won't be a problem, because eshell-tramp-initialize has to
be called (for each buffer) to register the functions.

em-tramp.el line 51:

  (make-local-variable 'eshell-complex-commands)
  (setq eshell-complex-commands
        (append '("su" "sudo")
	        	    eshell-complex-commands))

So if the module is enabled (and loaded, of course), and you disable it
and then create a new eshell buffer, running the commands su and sudo
will invoke the external commands, not the internal eshell/su and
eshell/sudo.

--Aidan

(Sorry for the duplicate; I keep hitting R instead of F in Gnus.)


  reply	other threads:[~2013-03-28 20:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1UKcBA-00086f-PW@vcs.savannah.gnu.org>
     [not found] ` <jwvip4dfxbh.fsf-monnier+emacs@gnu.org>
     [not found]   ` <87wqst2vw3.fsf@no8wireless.co.nz>
     [not found]     ` <jwv8v59dmlj.fsf-monnier+emacs@gnu.org>
2013-03-28  8:18       ` /srv/bzr/emacs/trunk r112148: Added eshell-tramp module Aidan Gauland
2013-03-28 10:19         ` Michael Albinus
2013-03-28 20:00           ` Aidan Gauland
2013-03-28 20:23             ` Eli Zaretskii
2013-03-28 22:02               ` Aidan Gauland
2013-03-29  5:38                 ` Eli Zaretskii
2013-03-28 21:01             ` Michael Albinus
2013-03-28 21:52               ` Aidan Gauland
2013-03-29  8:28                 ` Michael Albinus
2013-03-28 13:16         ` [Emacs-diffs] " Stefan Monnier
2013-03-28 20:03           ` Aidan Gauland [this message]
     [not found]           ` <87wqsrnvsh.fsf@dimension8.tehua.net>
     [not found]             ` <jwvfvzfdytf.fsf-monnier+emacs@gnu.org>
2013-03-29  0:09               ` Aidan Gauland
2013-03-29 20:30                 ` Stefan Monnier
2013-03-30  3:14                   ` Aidan Gauland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hajvnvgg.fsf@dimension8.tehua.net \
    --to=aidalgol@no8wireless.co.nz \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-diffs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).