ELPA queue.el weirdness

ELPA queue.el weirdness

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

I see that the GNU ELPA packages/queue/queue.el has the following:

 (defmacro queue-empty (queue)
   "Return t if QUEUE is empty, otherwise return nil."
   (null (queue-head queue)))
 
 (defmacro queue-first (queue)
   "Return the first element of QUEUE or nil if it is empty,
 without removing it from the QUEUE."
   (car (queue-head queue)))

I don't understand how these can work in their present
formulation, and think they should be changed to use either
‘backquote’ and ‘unquote’, or (preferably) ‘defsubst’.

Also i notice that the queue.el from the www.dr-qubit.org Git repo
includes ‘lexical-binding: t’ whereas the ELPA version does not.

Do you have any plans to do these small changes and release (on
the ELPA side, that is) a new version?  If not, any objections or
advice if i were to do it?

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: ELPA queue.el weirdness

[Stefan Monnier]

> Also i notice that the queue.el from the www.dr-qubit.org Git repo
> includes ‘lexical-binding: t’ whereas the ELPA version does not.

You could "git merge -t subtree" from that repository.


        Stefan

Re: ELPA queue.el weirdness

[Thien-Thi Nguyen]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

() Stefan Monnier <monnier@IRO.UMontreal.CA>
() Wed, 14 May 2014 15:05:08 -0400

   You could "git merge -t subtree" from that repository.

Thanks for the tip (with ‘s/-t/-s/’ i take it).

-- 
Thien-Thi Nguyen
   GPG key: 4C807502
   (if you're human and you know it)
      read my lisp: (responsep (questions 'technical)
                               (not (via 'mailing-list)))
                     => nil

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]