* Obsoleting hash-table-* functions in subr-x in favor of map-* functions
@ 2015-06-21 18:58 Nicolas Petton
2015-06-22 5:28 ` Bozhidar Batsov
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Petton @ 2015-06-21 18:58 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
Hi,
I'm thinking about obsoleting `hash-table-empty-p', `hash-table-keys'
and `hash-table-values' defined in subr-x in favor of their map-*
equivalent.
WDYT?
Cheers,
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsoleting hash-table-* functions in subr-x in favor of map-* functions
2015-06-21 18:58 Obsoleting hash-table-* functions in subr-x in favor of map-* functions Nicolas Petton
@ 2015-06-22 5:28 ` Bozhidar Batsov
2015-06-22 5:43 ` Bozhidar Batsov
2015-06-22 7:27 ` Nicolas Petton
0 siblings, 2 replies; 6+ messages in thread
From: Bozhidar Batsov @ 2015-06-22 5:28 UTC (permalink / raw)
To: Nicolas Petton; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
Sounds a bit strange to me. Those are somewhat basic hash-table-specific
stuff. If you're going to obsolete them, why not obsolete everything except
hash-table constructors? Somewhere a line has to be drawn.
Btw, I'm still not sure about the "map" naming, as this is a term that's
not used at all in Emacs Lisp terminology and will be the source of a lot
of confusing I guess.
On 21 June 2015 at 21:58, Nicolas Petton <nicolas@petton.fr> wrote:
> Hi,
>
> I'm thinking about obsoleting `hash-table-empty-p', `hash-table-keys'
> and `hash-table-values' defined in subr-x in favor of their map-*
> equivalent.
>
> WDYT?
>
> Cheers,
> Nico
> --
> Nicolas Petton
> http://nicolas-petton.fr
>
[-- Attachment #2: Type: text/html, Size: 1215 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsoleting hash-table-* functions in subr-x in favor of map-* functions
2015-06-22 5:28 ` Bozhidar Batsov
@ 2015-06-22 5:43 ` Bozhidar Batsov
2015-06-22 7:28 ` Nicolas Petton
2015-06-22 7:27 ` Nicolas Petton
1 sibling, 1 reply; 6+ messages in thread
From: Bozhidar Batsov @ 2015-06-22 5:43 UTC (permalink / raw)
To: Nicolas Petton; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
P.S. I'm aware this was borrowed from the likes of Clojure (as was seq),
but sometimes it's not a great idea to bring in external terminology 1:1.
Anyways, that's not major. When I added those hash-table specific function
the point was to extend a specific API, not to look for some generic
solution.
On 22 June 2015 at 08:28, Bozhidar Batsov <bozhidar@batsov.com> wrote:
> Sounds a bit strange to me. Those are somewhat basic hash-table-specific
> stuff. If you're going to obsolete them, why not obsolete everything except
> hash-table constructors? Somewhere a line has to be drawn.
>
> Btw, I'm still not sure about the "map" naming, as this is a term that's
> not used at all in Emacs Lisp terminology and will be the source of a lot
> of confusing I guess.
>
> On 21 June 2015 at 21:58, Nicolas Petton <nicolas@petton.fr> wrote:
>
>> Hi,
>>
>> I'm thinking about obsoleting `hash-table-empty-p', `hash-table-keys'
>> and `hash-table-values' defined in subr-x in favor of their map-*
>> equivalent.
>>
>> WDYT?
>>
>> Cheers,
>> Nico
>> --
>> Nicolas Petton
>> http://nicolas-petton.fr
>>
>
>
[-- Attachment #2: Type: text/html, Size: 1930 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsoleting hash-table-* functions in subr-x in favor of map-* functions
2015-06-22 5:28 ` Bozhidar Batsov
2015-06-22 5:43 ` Bozhidar Batsov
@ 2015-06-22 7:27 ` Nicolas Petton
2015-06-22 10:46 ` Bozhidar Batsov
1 sibling, 1 reply; 6+ messages in thread
From: Nicolas Petton @ 2015-06-22 7:27 UTC (permalink / raw)
To: Bozhidar Batsov; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Bozhidar Batsov <bozhidar@batsov.com> writes:
> Sounds a bit strange to me.
Might be. I was merely asking. But now I think it should be the
opposite: map should use hash-table-* functions for hash-tables whenever
possible.
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-22 10:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-21 18:58 Obsoleting hash-table-* functions in subr-x in favor of map-* functions Nicolas Petton
2015-06-22 5:28 ` Bozhidar Batsov
2015-06-22 5:43 ` Bozhidar Batsov
2015-06-22 7:28 ` Nicolas Petton
2015-06-22 7:27 ` Nicolas Petton
2015-06-22 10:46 ` Bozhidar Batsov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).