From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Gnus cleanup Date: Tue, 09 Feb 2016 15:13:26 +1100 Message-ID: <87h9hied21.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1454991255 13277 80.91.229.3 (9 Feb 2016 04:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Feb 2016 04:14:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: ding@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 09 05:14:06 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSzgj-0003bO-Pm for ged-emacs-devel@m.gmane.org; Tue, 09 Feb 2016 05:14:05 +0100 Original-Received: from localhost ([::1]:51613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSzgi-0006BU-Qd for ged-emacs-devel@m.gmane.org; Mon, 08 Feb 2016 23:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSzge-0006B6-Q8 for emacs-devel@gnu.org; Mon, 08 Feb 2016 23:14:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSzgb-0002Ik-IJ for emacs-devel@gnu.org; Mon, 08 Feb 2016 23:14:00 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:45811) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSzgb-0002If-BB for emacs-devel@gnu.org; Mon, 08 Feb 2016 23:13:57 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aSzgA-0007gq-U5; Tue, 09 Feb 2016 05:13:31 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aSzgA-0007gq-U5 MailScanner-NULL-Check: 1455596012.9918@qz93duPO0Dix2W1/mzUp8A X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199574 gmane.emacs.gnus.general:86803 Archived-At: I'm starting to do the Gnus de-compat cleanup now, I think. Removing the compat calls is easy enough, but should I also remove the compat functions themselves? For instance: (defalias 'gnus-window-inside-pixel-edges (if (fboundp 'window-inside-pixel-edges) 'window-inside-pixel-edges 'window-pixel-edges)) In Emacs, we usually mark functions as obsolete for a few years before removing them, but I kinda feel like it's rather unlikely that there will be any other usages of gnus-window-inside-pixel-edges after I clean up the Gnus sources. So I could just remove the compat function to. But it is theoretically feasible that somebody out there are calling gnus-window-inside-pixel-edges in their own code. (gnus-window-inside-pixel-edges is just one example. There's like a hundred of these...) So... just mark the compat functions as obsolete, or nuke them? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no