unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Petton <nicolas@petton.fr>
To: Damien Cassou <damien@cassou.me>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?
Date: Thu, 29 Jun 2017 14:21:03 +0200	[thread overview]
Message-ID: <87h8yzt26o.fsf@petton.fr> (raw)
In-Reply-To: <87d19tkfdh.fsf@cassou.me>

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Damien Cassou <damien@cassou.me> writes:

> Here is a new version. I took the opportunity to add a NEWS entry 
> and to reflect the change in the elisp manual.

Great, thanks!

> -(defun line-number-at-pos (&optional pos)
> -  "Return (narrowed) buffer line number at position POS.
> +(defun line-number-at-pos (&optional pos absolute-p)

Why not simply `absolute' instead of `absolute-p'. It's not a predicate,
is it?

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]

  reply	other threads:[~2017-06-29 12:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 12:12 Emacs master commit: "Add current-line in simple.el" - Wrong commit log? Kaushal Modi
2017-06-19 12:41 ` Nicolas Petton
2017-06-19 13:58   ` Kaushal Modi
2017-06-19 12:42 ` Nicolas Petton
2017-06-24  7:35   ` Damien Cassou
2017-06-29 12:21     ` Nicolas Petton [this message]
2017-07-03  7:03       ` Damien Cassou
2017-07-03 12:45         ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8yzt26o.fsf@petton.fr \
    --to=nicolas@petton.fr \
    --cc=damien@cassou.me \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).