From: Alex <agrambot@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Slightly extending commit 16b0520a9
Date: Sat, 05 Aug 2017 22:30:36 -0600 [thread overview]
Message-ID: <87h8xluxlf.fsf@lylat> (raw)
In-Reply-To: <jwvbmnt49xg.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Sun, 06 Aug 2017 00:08:25 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> cond = eval_sub (XCAR (args));
>>
>> if (!NILP (cond))
>> - return eval_sub (Fcar (XCDR (args)));
>> + return eval_sub (XCAR (XCDR (args)));
>
> I don't see anything in the preceding code that guarantees that `XCDR (args)`
> holds a cons, so I think XCAR here is unsafe.
The following line includes "XCDR (XCDR (args))", and the value of cond
should not affect the type of XCDR (args). If XCDR is allowed in this
case, then IIUC XCAR should be allowed as well.
I believe the reason why we can assume that XCDR (args) is a cons cell
is that `if' requires at least 2 (unevalled) arguments, so args must be
a list of at least length 2.
next prev parent reply other threads:[~2017-08-06 4:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 3:58 Slightly extending commit 16b0520a9 Alex
2017-08-06 4:08 ` Stefan Monnier
2017-08-06 4:30 ` Alex [this message]
2017-08-06 16:18 ` Stefan Monnier
2017-08-07 0:10 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8xluxlf.fsf@lylat \
--to=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).