Re: Emacs26: Quick thoughts on display-line-numbers-mode

[Alex <agrambot@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Alex <agrambot@gmail.com>
>> Cc: Matthew Plant <maplant95@gmail.com>,  emacs-devel@gnu.org
>> Date: Thu, 05 Oct 2017 17:24:15 -0600
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> That being said, shouldn't this face be part of the group display-line-
>> >> number? Faces for compilation errors are part of the the compilation
>> >> group. 
>> >
>> > My reasoning was that this is one of the basic faces we provide, so
>> > it's in the basic faces group.
>> 
>> It appears that a face can be added to multiple groups.
>
> Which other faces are in more than one group?

Here are some in face.el:
mode-line*
window-divider*
fringe
cursor
mouse
menu

>> Perhaps this should be done for the line-number* faces?
>
> If this is established practice, no objections here.

Okay, I've attached a patch which does this. Additionally, I added the
`display-line-numbers' group to the `convenience' group since (n)linum
belong to that group. nlinum belongs to 2 groups already, as do groups
such as `message' and `mode-line-faces', so it should also be fine.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: d-l-n --]
[-- Type: text/x-diff, Size: 1602 bytes --]

From 1b78dd8aa2757e9901b2e0ed69a9e7ea55350284 Mon Sep 17 00:00:00 2001
From: Alexander Gramiak <agrambot@gmail.com>
Date: Sat, 7 Oct 2017 15:02:01 -0600
Subject: [PATCH] Add line-number faces to the display-line-numbers group

* lisp/faces.el (line-number):
(line-number-current-line): Add to the display-line-numbers group.
* lisp/display-line-numbers.el (display-line-numbers): Add to the
convenience group.
---
 lisp/display-line-numbers.el | 1 +
 lisp/faces.el                | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/display-line-numbers.el b/lisp/display-line-numbers.el
index 3b6b101de4..15e0427915 100644
--- a/lisp/display-line-numbers.el
+++ b/lisp/display-line-numbers.el
@@ -36,6 +36,7 @@
 
 (defgroup display-line-numbers nil
   "Display line numbers in the buffer."
+  :group 'convenience
   :group 'display)
 
 (defcustom display-line-numbers-type t
diff --git a/lisp/faces.el b/lisp/faces.el
index 24ab1fa4f0..a5f1d1dd32 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2483,7 +2483,8 @@ line-number
 and text lines might move horizontally as you move through
 the buffer."
   :version "26.1"
-  :group 'basic-faces)
+  :group 'basic-faces
+  :group 'display-line-numbers)
 
 (defface line-number-current-line
   '((t :inherit line-number))
@@ -2497,7 +2498,8 @@ line-number-current-line
 from that of the `line-number' face could produce such
 unwanted effects."
   :version "26.1"
-  :group 'basic-faces)
+  :group 'basic-faces
+  :group 'display-line-numbers)
 
 (defface escape-glyph
   '((((background dark)) :foreground "cyan")
-- 
2.14.2