From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Markus Triska Newsgroups: gmane.emacs.devel Subject: Re: please review new branch feature/byte-unwind-protect Date: Sat, 27 Jan 2018 18:37:31 +0100 Message-ID: <87h8r719us.fsf@metalevel.at> References: <87inbtnobf.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517074598 28125 195.159.176.226 (27 Jan 2018 17:36:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Jan 2018 17:36:38 +0000 (UTC) User-Agent: Emacs/24.4 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 27 18:36:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efUOx-0006Z1-De for ged-emacs-devel@m.gmane.org; Sat, 27 Jan 2018 18:36:27 +0100 Original-Received: from localhost ([::1]:32858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efUQx-0005Tj-Ux for ged-emacs-devel@m.gmane.org; Sat, 27 Jan 2018 12:38:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efUQJ-0005TW-Ik for emacs-devel@gnu.org; Sat, 27 Jan 2018 12:37:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efUQF-0000oI-M9 for emacs-devel@gnu.org; Sat, 27 Jan 2018 12:37:51 -0500 Original-Received: from [195.159.176.226] (port=37646 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efUQF-0000mV-F0 for emacs-devel@gnu.org; Sat, 27 Jan 2018 12:37:47 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1efUO9-0003Wm-Hy for emacs-devel@gnu.org; Sat, 27 Jan 2018 18:35:37 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:g6bXZUMbH37Q2YzdcJHB+qEoAOs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222265 Archived-At: Hi Tom, Tom Tromey writes: > I recently wrote a couple of patches to add two new bytecodes to Emacs. > These make it possible to compile unwind-protect without the need to > introduce a closure for the unwind forms. Thank you very much for your work! I have one feature request that is related to unwind-protect, filed as issue #23963: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23963 This is only tangentially related to your immediate patch. However, as you are now working in this area, I would like to use the opportunity to ask you for your opinion on this construct. In my view, it would help to reliably solve a long-standing issue with unwind-protect and possible resource leaks. Would new instructions help with this construct? Thank you and all the best! Markus