unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Markus Triska <triska@metalevel.at>
To: emacs-devel@gnu.org
Subject: Re: please review new branch feature/byte-unwind-protect
Date: Sat, 27 Jan 2018 18:37:31 +0100	[thread overview]
Message-ID: <87h8r719us.fsf@metalevel.at> (raw)
In-Reply-To: 87inbtnobf.fsf@tromey.com

Hi Tom,

Tom Tromey <tom@tromey.com> writes:

> I recently wrote a couple of patches to add two new bytecodes to Emacs.
> These make it possible to compile unwind-protect without the need to
> introduce a closure for the unwind forms.

Thank you very much for your work!

I have one feature request that is related to unwind-protect, filed as
issue #23963:

   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23963

This is only tangentially related to your immediate patch. However, as
you are now working in this area, I would like to use the opportunity to
ask you for your opinion on this construct. In my view, it would help to
reliably solve a long-standing issue with unwind-protect and possible
resource leaks. Would new instructions help with this construct?

Thank you and all the best!
Markus




  parent reply	other threads:[~2018-01-27 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23  5:20 please review new branch feature/byte-unwind-protect Tom Tromey
2018-01-23  8:47 ` John Wiegley
2018-01-23 15:50   ` Tom Tromey
2018-01-23 16:37     ` Stefan Monnier
2018-01-27 17:37 ` Markus Triska [this message]
2018-01-27 21:28   ` Stefan Monnier
2018-02-03 19:43 ` Philipp Stephani
  -- strict thread matches above, loose matches on Subject: below --
2018-01-26  7:58 Rocky Bernstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8r719us.fsf@metalevel.at \
    --to=triska@metalevel.at \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).