From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Cochran Newsgroups: gmane.emacs.devel Subject: Re: [Patch] Enable byte-compile-error-on-wran for error-free files in lisp/ Date: Wed, 21 Feb 2018 18:29:34 -0800 Message-ID: <87h8q9n4dt.fsf@cochranmail.com> References: <87o9kii4an.fsf@cochranmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519266601 28735 195.159.176.226 (22 Feb 2018 02:30:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 22 Feb 2018 02:30:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 22 03:29:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eogdu-0006xk-C2 for ged-emacs-devel@m.gmane.org; Thu, 22 Feb 2018 03:29:54 +0100 Original-Received: from localhost ([::1]:35708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eogfv-00029P-Vn for ged-emacs-devel@m.gmane.org; Wed, 21 Feb 2018 21:32:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eogem-00023y-BP for emacs-devel@gnu.org; Wed, 21 Feb 2018 21:31:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eogdi-0005G4-7Y for emacs-devel@gnu.org; Wed, 21 Feb 2018 21:30:48 -0500 Original-Received: from vps28183.inmotionhosting.com ([23.235.221.66]:44290) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eogdh-0005D8-MM for emacs-devel@gnu.org; Wed, 21 Feb 2018 21:29:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cochranmail.com; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SAGh8I9OueXn83ekRjGpX0h/D6ZLN6MDcAbCcQrkTps=; b=hdgU3lkG0XXU0yAqzt3outBfa IwbjIyQbLLbHepLfd4JZ4T12Jzr1YM/vvjFPX2ZQUkAB+eQMBBRgiUEO0RKa2oQ8h3/yWdzQkrN1T 0tYrYdWHmskCrCzwXQUtfSoPI7t4blEO6527PRIaDk6hbXQruDG8CLlgjiLjjsGSxTQemCT/XhvkB gN5YN2a1+zJSZtIoEp5ArFIiLKeqLJ8bG5d+B7aaH0gC1uRAKZIrOc+u/0bLkVvFtNGYcLnLlX1BG mwI7tryRm3ldbuVtjx5OZadh1fF1HgGdSd/DroRlpK2kcOAWt2cauDNzmVaKKlcdK9H8lcXkGCYZD eetsNsHWw==; Original-Received: from 131-191-86-130.as.clicknet.org ([131.191.86.130]:35674 helo=SoraLaptop) by vps28183.inmotionhosting.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1eogde-0001qo-D1; Wed, 21 Feb 2018 18:29:38 -0800 In-Reply-To: (Noam Postavsky's message of "Wed, 21 Feb 2018 14:26:46 -0500") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps28183.inmotionhosting.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - cochranmail.com X-Get-Message-Sender-Via: vps28183.inmotionhosting.com: authenticated_id: robert@cochranmail.com X-Authenticated-Sender: vps28183.inmotionhosting.com: robert@cochranmail.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 23.235.221.66 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222974 Archived-At: Noam Postavsky writes: > On Wed, Feb 21, 2018 at 1:30 PM, Robert Cochran > wrote: > >> This patch is rather large - the email patch form is 600k. The reason >> for this is that I've touched quite a number of files - over 1,000 >> according to the Gitlab interface. > > If you instead set byte-compile-error-on-warn to t by default (e.g., > on the command line) and just set it to nil in files which trigger a > warning, would the patch be bigger or larger? According to my blacklist and whitelist files, 179 warning files vs 1319 non-warning files, so significantly smaller it seems. I'll look into modifying the Makefile.in to accommodate this. > By the way, I think it would be better to set it in the local > variables list at the end of the file, rather than in the first line. > For lexical-binding it's required to put it there for technical > reasons, but I think those don't apply to byte-compile-error-on-warn, > and that first line can get a bit crowded. I generated this mechanically via add-file-local-variable-prop-line in an Emacs Lisp batch script. Is there a mechanism by which I can use a-f-l-v-p-l or some other function to put it at the bottom? Thanks, -- ~Robert Cochran GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE E7B9 EC9A 872C 41B2 77C2