unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: emacs-26 52ccb24: ; * doc/os.texi (Batch Mode): use = after --eval
       [not found] ` <20180522133352.84CA8206CC@vcs0.savannah.gnu.org>
@ 2018-05-22 15:04   ` Michael Albinus
  2018-05-22 19:47     ` Philipp Stephani
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2018-05-22 15:04 UTC (permalink / raw)
  To: emacs-devel; +Cc: Philipp Stephani

p.stephani2@gmail.com (Philipp Stephani) writes:

Hi Philipp,

> -calls @var{function} with no arguments, or @samp{--eval @var{form}}.
> +calls @var{function} with no arguments, or @samp{--eval=@var{form}}.

Why that? The former is valid, and it is used everywhere in the Makefiles.

And we should touch the release branch only for essential changes, so
close to the release.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-26 52ccb24: ; * doc/os.texi (Batch Mode): use = after --eval
  2018-05-22 15:04   ` emacs-26 52ccb24: ; * doc/os.texi (Batch Mode): use = after --eval Michael Albinus
@ 2018-05-22 19:47     ` Philipp Stephani
  2018-05-23  8:01       ` Michael Albinus
  0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stephani @ 2018-05-22 19:47 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Philipp Stephani, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

Michael Albinus <michael.albinus@gmx.de> schrieb am Di., 22. Mai 2018 um
17:04 Uhr:

> p.stephani2@gmail.com (Philipp Stephani) writes:
>
> Hi Philipp,
>
> > -calls @var{function} with no arguments, or @samp{--eval @var{form}}.
> > +calls @var{function} with no arguments, or @samp{--eval=@var{form}}.
>
> Why that? The former is valid, and it is used everywhere in the Makefiles.
>

See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24949#6: "long options
are documented to
need the equals sign"


>
> And we should touch the release branch only for essential changes, so
> close to the release.
>

It's not essential, but it's an obviously safe documentation fix.

[-- Attachment #2: Type: text/html, Size: 1288 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: emacs-26 52ccb24: ; * doc/os.texi (Batch Mode): use = after --eval
  2018-05-22 19:47     ` Philipp Stephani
@ 2018-05-23  8:01       ` Michael Albinus
  0 siblings, 0 replies; 3+ messages in thread
From: Michael Albinus @ 2018-05-23  8:01 UTC (permalink / raw)
  To: Philipp Stephani; +Cc: Philipp Stephani, emacs-devel

Philipp Stephani <p.stephani2@gmail.com> writes:

Hi Philipp,

>     Why that? The former is valid, and it is used everywhere in the
>     Makefiles.
>
> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24949#6: "long
> options are documented to need the equals sign"

I see. Maybe you could add the bug number to the commit message, next
time? This would avoid this kind of comment, perhaps.

>     And we should touch the release branch only for essential changes,
>     so close to the release.
>
> It's not essential, but it's an obviously safe documentation fix. 

I know. I'm writing software for decades, and I've managed several times
to damage a release with "it's just a one-line patch, I cannot make it
wrong". Therefore, I'm extremely conservative with last minute
changes. And I still believe your patch could have waited for opening
the release branch for Emacs 26.1.50.

Best regards, Michael.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-23  8:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20180522133350.22071.15938@vcs0.savannah.gnu.org>
     [not found] ` <20180522133352.84CA8206CC@vcs0.savannah.gnu.org>
2018-05-22 15:04   ` emacs-26 52ccb24: ; * doc/os.texi (Batch Mode): use = after --eval Michael Albinus
2018-05-22 19:47     ` Philipp Stephani
2018-05-23  8:01       ` Michael Albinus

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).