From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] open bookmark in other frame Date: Thu, 08 Nov 2018 16:54:18 -0800 Message-ID: <87h8grcbph.fsf@red-bean.com> References: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr> <9f2ed5a8-96c0-aa6c-b9c8-3b0f73f20aa6@luyten.fr> <357cd187-ad96-4cc6-9c01-cca87282f165@default> <8736taoo4y.fsf@red-bean.com> <6a73c984-002a-f767-6a96-3fb0822489de@luyten.fr> <87k1lv5mxf.fsf@red-bean.com> Reply-To: Karl Fogel NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541724769 935 195.159.176.226 (9 Nov 2018 00:52:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2018 00:52:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Pierre-Yves Luyten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 09 01:52:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKv2R-0008UX-RR for ged-emacs-devel@m.gmane.org; Fri, 09 Nov 2018 01:52:43 +0100 Original-Received: from localhost ([::1]:59689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKv4Y-0007px-7y for ged-emacs-devel@m.gmane.org; Thu, 08 Nov 2018 19:54:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKv4R-0007pg-Qr for emacs-devel@gnu.org; Thu, 08 Nov 2018 19:54:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKv4L-0005Nu-Qo for emacs-devel@gnu.org; Thu, 08 Nov 2018 19:54:45 -0500 Original-Received: from mail-it1-x141.google.com ([2607:f8b0:4864:20::141]:35785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKv4J-0005GY-Qh for emacs-devel@gnu.org; Thu, 08 Nov 2018 19:54:40 -0500 Original-Received: by mail-it1-x141.google.com with SMTP id v11so961632itj.0 for ; Thu, 08 Nov 2018 16:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version; bh=TBbngoBAkR/8meIT2So2ewFxlQafO0XONSZ90F7i1Vs=; b=LIxyOqzTQEq5UBay+SqXgIlZePmKtMvO3DlhXZYa1Sxsn86sT9zisostBpb66NLeIz 5nr0JSyFS4MPRh5CpW/FbRkTbW+nsVX0rbPDLFyDc9Pv3q9BDaIeUgTzX8fbmUvCJkQJ XEdX1Mgi4yz0SW4JIq8aUCYL+FJZyWKGGMXNazfT6IRsczNzy+KcZYtsN973REhbIhfa 4g3O8hn60/IFCBZv+l25A2OARwoMDfuLKnnefW62W2N0VgFvUAZS0PAMboXN9XIYQ8Fq zk3twfpLngGk3gtXoA56yAsobww1bgQ+sfW35rOlUurpjgtpvcPt86OpP+WffsYr8os4 aWVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:reply-to :date:in-reply-to:message-id:user-agent:mime-version; bh=TBbngoBAkR/8meIT2So2ewFxlQafO0XONSZ90F7i1Vs=; b=m+5IQlzFXGb/cPimAhEFmDTkimd2+ClTQeDz1GcoRCoughEZ8JufuIMIhVYUREZJ6x 8Em5JQYe6W5fwVrP6obkw97elJoGJABxV/EcZMYwWRHoIEucMZ901BfA/UsoWlLCnGOt x6SsuQfhL4deZiJg9vDhU5zPy52bIlVAujlzb48c81x1oj0IkmqSxYryXvYplG6x9xYy 0+opVj7F+AWNqGdsv/X9yE7+eGbkNz4Zajw28SAgrgvSM7hcLh+N0PhDT9+kDRMnaHKq dcJxYmhOYUasr6oGuMWIk6Nc8vFWsfwnnr1rzr3NDk2Al0AHYg8SgB94aOXHPyHItd+8 MQmg== X-Gm-Message-State: AGRZ1gKHUR5V6xtW2KQds+/XYvw36nyCeFz530ORHLF14DgxWSUk+eBg 0q5+nl1op/1M3Wk3rQ1Vv6GMoVXV X-Google-Smtp-Source: AJdET5cTNMzzPyiifT2k6woYUG9VHByDLDSU4c+D9QZAV6xd7BvZbphJS0N025Cz0bvYkzi4AEda+g== X-Received: by 2002:a24:d1c6:: with SMTP id w189-v6mr597818itg.38.1541724873961; Thu, 08 Nov 2018 16:54:33 -0800 (PST) Original-Received: from klen ([75.104.69.124]) by smtp.gmail.com with ESMTPSA id l70-v6sm2408526itb.29.2018.11.08.16.54.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 16:54:32 -0800 (PST) In-Reply-To: (Pierre-Yves Luyten's message of "Sun, 4 Nov 2018 22:10:12 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::141 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231061 Archived-At: Pierre-Yves Luyten writes: >Oops i used to just work with eval-buffer on the lisp i needed, and i >can see now this is not the right workflow for testing a patch. > >So now i rather build Emacs to test patch properly, and obviously as >you wrote adding the autoload magic comment fixed the issue. So here >is the patch with this. Thanks, Pierre-Yves. I've applied the patch and committed it now. As it's a new feature, not a bug fix, it went to the master branch, so it'll be in the next major release of Emacs. I modified the log message a bit. I changed it to match the style recommended in CONTRIBUTING (that is, to put a summary line at the top before giving a ChangeLog-style entry below that), and I added a line at the bottom noting that I had applied the patch, because otherwise there would be no way to trace the full audit trail. By the way, I realize that when you wrote the log message you were probably just following the examples you saw from looking at existing log messages. Some developers are still using an older log message format, but the CONTRIBUTING file is clear about the modern format, so I though this change should provide an up-to-date example for whoever the next contributor is :-). Here's the commit: | commit f3345dee4b40293547d10963c6cb242a62e424ba | Author: Pierre-Yves Luyten | Date: Sat Oct 13 22:06:41 2018 +0200 | | Add functions to open a bookmark in another frame | | * lisp/bookmark.el (bookmark-jump-other-frame): New function. | Bind in bookmark-map. | (bookmark-bmenu-other-frame): New function. | Bind in bookmark-bmenu-mode-map. | | Patch applied by Karl Fogel. Thank you for the improvement to Emacs! Best regards, -Karl