unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist
Date: Fri, 15 Feb 2019 16:51:57 +0100	[thread overview]
Message-ID: <87h8d5can6.fsf@gmx.de> (raw)
In-Reply-To: <83o97dm53f.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Feb 2019 17:41:40 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> > +        ;; Emulate what we do on Posix hosts when we call access-file
>> > +        ;; in insert-directory.
>> > +	(signal 'file-error
>> > +                (list "Reading directory"
>> > +                      "Directory doesn't exist or is inaccessible"
>> > +                      file))))))
>> 
>> On GNU/Linux, it is `file-missing' (introduced in Emacs 26).
>
> I know.  But ls-lisp doesn't know whether it failed because the
> directory doesn't exist, or does exist but isn't accessible, and
> trying to discern between these two situations doesn't seem worth it.

Hmm. This reminds me, that `tramp-test17-insert-directory' does not
check any error condition. If I would add this, this subtle detail would
count ...

(Not that anybody in real life would care ...)

Best regards, Michael.



      reply	other threads:[~2019-02-15 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190215134656.1071.93029@vcs0.savannah.gnu.org>
     [not found] ` <20190215134658.0E9A3204F1@vcs0.savannah.gnu.org>
2019-02-15 14:10   ` master 00b8c7e: Make ls-lisp.el behave like Posix hosts when directory doesn't exist Michael Albinus
2019-02-15 15:41     ` Eli Zaretskii
2019-02-15 15:51       ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h8d5can6.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).