From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Regexp error scan (March 26) Date: Wed, 27 Mar 2019 03:43:11 +0000 Message-ID: <87h8bpvv74.fsf@tcd.ie> References: <0E648A80-8673-44DB-B481-981474AC3D7C@acm.org> <77419a89-ce9f-919b-c221-c7a3b938587a@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110411"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 27 04:43:33 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8zTO-000Sbb-JR for ged-emacs-devel@m.gmane.org; Wed, 27 Mar 2019 04:43:30 +0100 Original-Received: from localhost ([127.0.0.1]:41414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8zTN-0001wd-HL for ged-emacs-devel@m.gmane.org; Tue, 26 Mar 2019 23:43:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59547) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8zTA-0001um-IF for emacs-devel@gnu.org; Tue, 26 Mar 2019 23:43:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8zT9-0006We-Lo for emacs-devel@gnu.org; Tue, 26 Mar 2019 23:43:16 -0400 Original-Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:36971) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8zT9-0006Vl-1b for emacs-devel@gnu.org; Tue, 26 Mar 2019 23:43:15 -0400 Original-Received: by mail-ed1-x529.google.com with SMTP id v21so12723095edq.4 for ; Tue, 26 Mar 2019 20:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CeMcbOxjQMQBH8Raz6YqJZUYIHT8utQwE8FmekUPJfM=; b=wBEpDHr0+DBNyBHTTPIiGNjVzcgGODN3mfbFBx25DG5t+TS5sP3K2zl3aepMvhCSsJ L7HSez3ntJxGv+gyM/u1aVeRDAq8q8xfXOZt+iiUNBcQ1EB+QSatuULiNBXzSs/70e0v n+z+VwZKLgX3SVguG1GP9BMX5zJTu8qtjzPvK8wsBLP3PBY+wwU5TIDBHZYlsw2UZOEw dkl+VP15H8XDX+cAaluorSG36xI6dUDPx/O6H4pE15oqZCdbieBJ57wfRwkyU1PJ8l9s IbvVLxlvnWW2Qasm4LZxSX6ji6OvTkWhb+NjZh4z76WoO6IYYxUB2RbYzv9zvhFdKTqd aS6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CeMcbOxjQMQBH8Raz6YqJZUYIHT8utQwE8FmekUPJfM=; b=P4/dp4X8RWGP0EuBlcekac+Xp5Cs4qav9eWTWEQOa/ZbyWxlE+Qb5B1UqBMmLcCpz6 chcAM0huISxgekp6Q6fFVw6kOUQlD/ug7WZpuwwxNI3WekJT3CCrobpkBK1ahJVOWncU Z/vUaU2MonLjnyhjibs+ihb2r2lfk+SsgUc5l3ahMzrXmv7ZAf6wJuTfF6aPIxBgoaJK vabg1geE5nS4K+5CDX2blgMxXimZaloC0vFyHeH2An60DKnS1DuCl4to7Mu7uSCBaJq1 res3AG0XBUW+dmrSMDPJXMNR/mBGCRCEj0QydZ360/IApbLULFes8wdV/nNkUK4s/oy6 Z6ZA== X-Gm-Message-State: APjAAAW7oCSFiIrK+cucHpSpj3jqhmMX1dI/CWVLXaUGa91SHHAmpABp 4OQw0BqPD6HuWLPmFLbfZoWthWSeV6k= X-Google-Smtp-Source: APXvYqxuqvR6gJc018yNFvqfKbz/2JjQL0wHZa2t/K2NzF1sZ87s6Oz5wFSaT/pgsnH4D9R1egvOLA== X-Received: by 2002:a17:906:3581:: with SMTP id o1mr19093682ejb.163.1553658193033; Tue, 26 Mar 2019 20:43:13 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id l9sm3244135edr.48.2019.03.26.20.43.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 26 Mar 2019 20:43:12 -0700 (PDT) In-Reply-To: <77419a89-ce9f-919b-c221-c7a3b938587a@cs.ucla.edu> (Paul Eggert's message of "Tue, 26 Mar 2019 19:10:05 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::529 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234761 Archived-At: Paul Eggert writes: > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index bcaa3e4525..e34487de27 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -67,6 +67,7 @@ > (load "erc-loaddefs" nil t) > > (eval-when-compile (require 'cl-lib)) > +(require 'cl-seq) > (require 'font-lock) > (require 'pp) > (require 'thingatpt) > @@ -2522,10 +2523,8 @@ erc-lurker-maybe-trim > non-nil." > (if erc-lurker-trim-nicks > (replace-regexp-in-string > - (format "[%s]" > - (mapconcat (lambda (char) > - (regexp-quote (char-to-string char))) > - erc-lurker-ignore-chars "")) > + (regexp-opt (cl-delete-duplicates > + (mapcar #'char-to-string erc-lurker-ignore-chars))) > "" nick) > nick)) regexp-opt already deletes duplicates, so you can just: (regexp-opt (mapcar #'char-to-string erc-lurker-ignore-chars)) Besides, cl-delete-duplicates defaults to eql for equality, so it's a no-op here anyway. Thanks, -- Basil