From: Sven Joachim <svenjoac@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change
Date: Wed, 02 Oct 2019 18:57:08 +0200 [thread overview]
Message-ID: <87h84rxezf.fsf@turtle.gmx.de> (raw)
In-Reply-To: <jwva7akzete.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 01 Oct 2019 11:08:31 -0400")
On 2019-10-01 11:08 -0400, Stefan Monnier wrote:
> Hi Lars,
>
>> --- a/lisp/emacs-lisp/bytecomp.el
>> +++ b/lisp/emacs-lisp/bytecomp.el
>> @@ -124,7 +124,7 @@
>> (require 'backquote)
>> (require 'macroexp)
>> (require 'cconv)
>> -(eval-when-compile (require 'compile))
>> +(require 'compile)
>
> This is a bad change.
>
> It brings in many more packages, and every additional package brought
> in reduces the quality of our warnings (e.g. if any of the packages
> (transitively) loaded load cl-lib, then we fail to signal when
> a package uses cl-lib functionality without requiring cl-lib).
Indeed, this is bug #30635, mentioned in the comments you had written
just around Lars' changes:
,----
| ;; Refrain from using cl-lib at run-time here, since it otherwise prevents
| ;; us from emitting warnings when compiling files which use cl-lib without
| ;; requiring it! (bug#30635)
`----
> We should try and find some other solution.
Cheers,
Sven
prev parent reply other threads:[~2019-10-02 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191001144135.32717.19241@vcs0.savannah.gnu.org>
[not found] ` <20191001144137.1032C20927@vcs0.savannah.gnu.org>
2019-10-01 15:08 ` [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change Stefan Monnier
2019-10-01 15:22 ` Lars Ingebrigtsen
2019-10-01 21:30 ` Stefan Monnier
2019-10-03 15:18 ` Lars Ingebrigtsen
2019-10-02 16:57 ` Sven Joachim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h84rxezf.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).