From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Emacs regexp scan (Sep 29) Date: Sat, 05 Oct 2019 18:59:53 +0200 Message-ID: <87h84n6sc6.fsf@gnus.org> References: <1697CA97-B2E6-4202-B14D-99DCF93954FD@acm.org> <02405f0d-788f-1b87-0269-b06eb2d67ff8@cs.ucla.edu> <83zhif4nq6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173047"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: mattiase@acm.org, Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 05 19:02:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGnRx-000ick-08 for ged-emacs-devel@m.gmane.org; Sat, 05 Oct 2019 19:02:33 +0200 Original-Received: from localhost ([::1]:58060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGnRk-0006PP-6p for ged-emacs-devel@m.gmane.org; Sat, 05 Oct 2019 13:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53033) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGnQM-0006P3-Sf for emacs-devel@gnu.org; Sat, 05 Oct 2019 13:00:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGnQK-0002zA-J5 for emacs-devel@gnu.org; Sat, 05 Oct 2019 13:00:53 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:41592) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGnPc-0002HP-K5; Sat, 05 Oct 2019 13:00:52 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGnPN-0000f5-Kr; Sat, 05 Oct 2019 18:59:56 +0200 In-Reply-To: <83zhif4nq6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Oct 2019 11:10:09 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240625 Archived-At: Eli Zaretskii writes: >> Thanks, I installed the attached patch, which I hope fixes all the bugs >> and style glitches uncovered by that scan, along with some other style >> glitches I noticed in the neighborhood. > > I question the need for "fixing" those "style glitches" (and even the > very existence of a "style glitch", which sounds like a contradiction > of terms to me). What's confusing to me is why regexps in particular are being subjected to these stylistic rewrites. There's a bunch of styles being used in Emacs Lisp code, but we avoid doing mass fixups (according to one preference or another) of working code, because non-functional code churn makes maintenance more difficult. I mean, I prefer (when foo (do-something)) over (if foo (do-something)) or (and foo (do-something)) but I hope that nobody would do a mass-rewrite of the Emacs code base to prefer `when' here, because it'd make diving into the history of the code a nightmare. So what's so special about regexps that "[-+]" has to be mass-rewritten as "[+-]"? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no